Differential D17950

Add Pinboard Items to Timeline
ClosedPublic
Actions

Authored by chad on May 18 2017, 5:25 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T10293: Plan rest of "CoverImage" feature

Commits

rP1599c56217a1: Add Pinboard Items to Timeline

Summary

This allows adding of pinboard items to a timeline. I'm hoping we can get this in for Maniphest (Pholio, Cover Image) and Macro (because, Macro), but unsure how to scalably do this. Anyways, here's the front end.

Test Plan

Make some fake timeline items in UIExamples, test mobile, tablet, and desktop breakpoints.

Diff Detail

Repository

rP Phabricator

Branch

render-image-timeline (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17085
Build 22848: Run Core Tests
Build 22847: arc lint + arc unit

Event Timeline

chad created this revision.May 18 2017, 5:25 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 18 2017, 5:25 PM

Harbormaster completed remote builds in B17085: Diff 43174.May 18 2017, 5:26 PM

chad edited the test plan for this revision. (Show Details)May 18 2017, 5:27 PM

Looks promising to me. I think we can make this work without too much hardship.

This revision is now accepted and ready to land.May 18 2017, 5:32 PM

typo

Yeah I started to force something into transactions but realized it'd bite me in the end if it wasn't scalable. At least pinboard for image display should work in most/all cases and case be tweaked as needed (lightbox).

Harbormaster completed remote builds in B17087: Diff 43176.May 18 2017, 5:34 PM

Closed by commit rP1599c56217a1: Add Pinboard Items to Timeline (authored by chad, committed by chad). · Explain WhyMay 18 2017, 5:35 PM

This revision was automatically updated to reflect the committed changes.

chad added a task: T10293: Plan rest of "CoverImage" feature.May 18 2017, 5:35 PM