Differential D17945

Restore the "buoyant" header in Differential
ClosedPublic
Actions

Authored by epriestley on May 17 2017, 9:55 PM.

Details

Reviewers

chad

Maniphest Tasks

T1591: Differential "buoyant" header has been temporarily disabled

Commits

rPfb9f3cc0b4ca: Restore the "buoyant" header in Differential

Summary

Fixes T1591. This was removed long ago because it was a mess to implement and caused a bunch of weird issues, and also my tolerance for dealing with weird JS issues was much, much lower.

I have now survived the fires of JX.Scrollbar and would love to address 200 small nitpicks about obscure browser behaviors on Linux, so open the floodgates again.

A secondary goal here is to create room to add a global view state menu on the right, with 300 options like "hide all inlines", "hide done inlines", "hide collapsed inlines", "hide ghosts", "show ghosts", "enable filetree", "disable filetree", etc, etc. Not sure how much of this I'll actually do. I have one more experiment I want to try first.

Test Plan

Screen Shot 2017-05-17 at 2.38.36 PM.png (760×1 px, 114 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 17 2017, 9:55 PM

Harbormaster completed remote builds in B17076: Diff 43160.May 17 2017, 9:56 PM

chad accepted this revision.May 18 2017, 3:47 PM

This revision is now accepted and ready to land.May 18 2017, 3:47 PM

i am excite.

ftdysa awarded a token.May 18 2017, 4:53 PM

avivey awarded a token.May 18 2017, 5:18 PM

I expect to keep tweaking this and receive 20 pieces of conflicting feedback about it, but I'm more confident we can make it stick now than I was in 2012.

Closed by commit rPfb9f3cc0b4ca: Restore the "buoyant" header in Differential (authored by epriestley, committed by epriestley). · Explain WhyMay 18 2017, 5:24 PM

This revision was automatically updated to reflect the committed changes.