" IDs on left-hand-side of image changesets
ClosedPublic
Actions

Authored by epriestley on May 17 2017, 12:54 PM.

Tags

None

Referenced Files

	F18068351: D17926.id43116.diff
	Mon, Aug 4, 3:11 PM

	F17924121: D17926.id.diff
	Wed, Jul 30, 9:18 AM

	F17915114: D17926.diff
	Tue, Jul 29, 8:10 PM

	F17851069: D17926.diff
	Sun, Jul 27, 10:51 AM

	Unknown Object (File)
	Jun 18 2025, 7:06 PM

	Unknown Object (File)
	Apr 29 2025, 10:04 AM

	Unknown Object (File)
	Apr 6 2025, 3:21 AM

	Unknown Object (File)
	Apr 4 2025, 3:00 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T7682: JS Errors when mousing over image diff comments, right side only

Commits

rP422eb9db837d: Correct the generation of "<th />" IDs on left-hand-side of image changesets

Summary

Fixes T7682. The left-hand-side "<th />" row did not generate with the correct ID.

(I couldn't reproduce the exact issue described in T7682, but hovering comments on either side now works properly for me.)

Test Plan

Screen Shot 2017-05-17 at 5.19.15 AM.png (1×2 px, 1 MB)

Diff Detail

Repository

rP Phabricator

Branch

inline17

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17043
Build 22791: Run Core Tests
Build 22790: arc lint + arc unit

Event Timeline

epriestley created this revision.May 17 2017, 12:54 PM

Harbormaster completed remote builds in B17043: Diff 43115.May 17 2017, 12:55 PM

chad accepted this revision.May 17 2017, 1:22 PM

This revision is now accepted and ready to land.May 17 2017, 1:22 PM

Closed by commit rP422eb9db837d: Correct the generation of "<th />" IDs on left-hand-side of image changesets (authored by epriestley, committed by epriestley). · Explain WhyMay 17 2017, 1:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetTwoUpRenderer.php

6 lines

Diff 43115

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Correct the generation of "<th />" IDs on left-hand-side of image changesetsClosedPublicActions