Allow setting of button colors in headers
ClosedPublic
Actions

Authored by chad on May 17 2017, 3:15 AM.

Tags

None

Referenced Files

	F13176331: D17922.diff
	Wed, May 8, 12:51 PM

	Unknown Object (File)
	Fri, May 3, 6:13 AM

	Unknown Object (File)
	Thu, May 2, 8:36 AM

	Unknown Object (File)
	Thu, Apr 25, 1:04 AM

	Unknown Object (File)
	Sun, Apr 14, 6:20 AM

	Unknown Object (File)
	Thu, Apr 11, 8:45 AM

	Unknown Object (File)
	Apr 2 2024, 10:04 AM

	Unknown Object (File)
	Feb 9 2024, 6:43 PM

View All 79 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP6ecd6980a142: Allow setting of button colors in headers

Summary

We currently override button color for headers, since the default is blue, but if a developer sets a specific color, we should respect that.

Test Plan

Set a button in the header to green and see green. See grey everywhere else.

Diff Detail

Repository

rP Phabricator

Branch

button-color (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17038
Build 22784: Run Core Tests
Build 22783: arc lint + arc unit

Event Timeline

chad created this revision.May 17 2017, 3:15 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 17 2017, 3:15 AM

Harbormaster completed remote builds in B17038: Diff 43110.May 17 2017, 3:16 AM

epriestley accepted this revision.May 17 2017, 11:41 AM

This revision is now accepted and ready to land.May 17 2017, 11:41 AM

Closed by commit rP6ecd6980a142: Allow setting of button colors in headers (authored by chad, committed by chad). · Explain WhyMay 17 2017, 1:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIButtonView.php

4 lines

PHUIHeaderView.php

4 lines

Diff 43110

View Options

src/view/phui/PHUIButtonView.php