Allow setting of button colors in headers
ClosedPublic
Actions

Authored by chad on May 17 2017, 3:15 AM.

Tags

None

Referenced Files

	F18601210: D17922.diff
	Sat, Sep 13, 11:48 AM

	F18600808: D17922.id43117.diff
	Sat, Sep 13, 10:38 AM

	F18593400: D17922.id.diff
	Fri, Sep 12, 2:48 PM

	F18589610: D17922.id43117.diff
	Fri, Sep 12, 3:48 AM

	F18417975: D17922.id.diff
	Sat, Aug 30, 12:31 PM

	F18393907: D17922.diff
	Fri, Aug 29, 9:33 AM

	F18103842: D17922.id.diff
	Aug 10 2025, 8:06 AM

	F18102681: D17922.id43110.diff
	Aug 9 2025, 10:42 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP6ecd6980a142: Allow setting of button colors in headers

Summary

We currently override button color for headers, since the default is blue, but if a developer sets a specific color, we should respect that.

Test Plan

Set a button in the header to green and see green. See grey everywhere else.

Diff Detail

Repository

rP Phabricator

Branch

button-color (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17038
Build 22784: Run Core Tests
Build 22783: arc lint + arc unit

Event Timeline

chad created this revision.May 17 2017, 3:15 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 17 2017, 3:15 AM

Harbormaster completed remote builds in B17038: Diff 43110.May 17 2017, 3:16 AM

epriestley accepted this revision.May 17 2017, 11:41 AM

This revision is now accepted and ready to land.May 17 2017, 11:41 AM

Closed by commit rP6ecd6980a142: Allow setting of button colors in headers (authored by chad, committed by chad). · Explain WhyMay 17 2017, 1:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIButtonView.php

4 lines

PHUIHeaderView.php

4 lines

Diff 43110

View Options

src/view/phui/PHUIButtonView.php