Differential D17914

Migrate Pholio inline comments to modular transactions
ClosedPublic
Actions

Authored by amckinley on May 16 2017, 7:12 PM.

Tags

None

Referenced Files

	F15526757: D17914.id43092.diff
	Mon, Apr 21, 11:01 PM

	F15526707: D17914.id43092.diff
	Mon, Apr 21, 10:24 PM

	F15521296: D17914.id.diff
	Sun, Apr 20, 12:53 PM

	F15517912: D17914.diff
	Sat, Apr 19, 9:28 AM

	F15450985: D17914.id43093.diff
	Fri, Mar 28, 7:28 PM

	F15434689: D17914.diff
	Tue, Mar 25, 4:55 AM

	F15433293: D17914.id43093.diff
	Mar 24 2025, 10:29 PM

	F15422932: D17914.id43093.diff
	Mar 22 2025, 11:29 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T12626: Update Pholio for Modular Transactions

Commits

rP6888472b567e: Migrate Pholio inline comments to modular transactions

Summary

Fixes T12626.

Test Plan

Made lots of comments, confirmed no UI changes

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

amckinley created this revision.May 16 2017, 7:12 PM

Herald added a subscriber: epriestley. · View Herald TranscriptMay 16 2017, 7:12 PM

Harbormaster completed remote builds in B17020: Diff 43092.May 16 2017, 7:13 PM

epriestley accepted this revision.May 16 2017, 7:20 PM

epriestley added inline comments.

src/applications/pholio/xaction/PholioMockInlineTransaction.php
30–32	I think you should be able to remove this: we should already automatically detect that transactions which apply comments have an effect (but maybe didn't when Pholio v1 was written).

This revision is now accepted and ready to land.May 16 2017, 7:20 PM

amckinley marked an inline comment as done.May 16 2017, 7:21 PM

amckinley added inline comments.

src/applications/pholio/xaction/PholioMockInlineTransaction.php
30–32	Not currently:

whelp

Closed by commit rP6888472b567e: Migrate Pholio inline comments to modular transactions (authored by amckinley, committed by amckinley). · Explain WhyMay 16 2017, 7:22 PM

This revision was automatically updated to reflect the committed changes.

amckinley marked an inline comment as done.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

pholio/

controller/

PholioMockCommentController.php

2 lines

editor/

PholioMockEditor.php

20 lines

storage/

PholioTransaction.php

60 lines

view/

PholioTransactionView.php

9 lines

xaction/

PholioMockInlineTransaction.php

33 lines

Diff 43093

src/__phutil_library_map__.php

Loading...

src/applications/pholio/controller/PholioMockCommentController.php

Loading...

src/applications/pholio/editor/PholioMockEditor.php

Loading...

src/applications/pholio/storage/PholioTransaction.php

Loading...

src/applications/pholio/view/PholioTransactionView.php

Loading...

src/applications/pholio/xaction/PholioMockInlineTransaction.php

Loading...