Ref T12625. Moves TYPE_TITLE to modular transaction.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12625: Update Phriction for Modular Transactions
- Commits
- rPa53d387ea6a0: Move Phriction Title transaction to Modular Transactions
New Document, Edit Document, test validation, verify feed stories.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/applications/phriction/editor/PhrictionTransactionEditor.php | ||
---|---|---|
495–502 | oops, I think I need to move this over too. |
Comment Actions
Feel free to just delete all the "get/setprocesscontentversionerror" junk if that makes things easier, and we can file a task like "make this work better". The way it works now isn't great and won't work with Conduit anyway.
Comment Actions
Well, I guess it's kiiiiiind of a regression to not have a warning at all, I think we added it because someone was actually hitting it? I vaguely recall it ruining someone's life 100x the worst.
Comment Actions
But the title field shouldn't really matter or need the check -- if you and someone else rename a document simultaneously it seems fine to just use "last save wins", at least for now.