Page MenuHomePhabricator

Move Phriction Title transaction to Modular Transactions
ClosedPublic

Authored by chad on May 16 2017, 5:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 29, 10:39 AM
Unknown Object (File)
Sun, Nov 13, 8:55 AM
Unknown Object (File)
Fri, Nov 11, 8:37 PM
Unknown Object (File)
Oct 3 2022, 9:32 AM
Unknown Object (File)
Oct 1 2022, 6:02 AM
Unknown Object (File)
Sep 29 2022, 3:28 AM
Unknown Object (File)
Sep 27 2022, 2:29 AM
Unknown Object (File)
Sep 25 2022, 8:55 AM
Subscribers

Details

Summary

Ref T12625. Moves TYPE_TITLE to modular transaction.

Test Plan

New Document, Edit Document, test validation, verify feed stories.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/phriction/editor/PhrictionTransactionEditor.php
495–502

oops, I think I need to move this over too.

Feel free to just delete all the "get/setprocesscontentversionerror" junk if that makes things easier, and we can file a task like "make this work better". The way it works now isn't great and won't work with Conduit anyway.

Well, I guess it's kiiiiiind of a regression to not have a warning at all, I think we added it because someone was actually hitting it? I vaguely recall it ruining someone's life 100x the worst.

But the title field shouldn't really matter or need the check -- if you and someone else rename a document simultaneously it seems fine to just use "last save wins", at least for now.

then this is ready for review

This revision is now accepted and ready to land.May 16 2017, 6:06 PM
This revision was automatically updated to reflect the committed changes.