Page MenuHomePhabricator

Add Differential keyboard shortcuts for "mark done" and "hide/show"
ClosedPublic

Authored by epriestley on May 16 2017, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 2:15 AM
Unknown Object (File)
Thu, Apr 25, 1:31 AM
Unknown Object (File)
Thu, Apr 11, 9:04 AM
Unknown Object (File)
Sun, Apr 7, 12:43 AM
Unknown Object (File)
Mar 31 2024, 5:59 PM
Unknown Object (File)
Mar 31 2024, 6:56 AM
Unknown Object (File)
Mar 1 2024, 2:31 AM
Unknown Object (File)
Feb 14 2024, 6:26 PM
Subscribers
None

Details

Summary

Fixes T8130. Allows selected comments to be shown/hidden (with "q") or marked done/not-done (with "w").

(These key selections are because "qwer" are right next to each other on QWERTY keyboards, and now mean "hide, done, edit, reply".)

Also, allow "N" and "P" to do next/previous inline, including hidden inlines. This makes "q" to hide/show a little more powerful and a little easier to undo.

Test Plan

Used "q", "w", "N" and "P" to navigate and interact with comments.

Diff Detail

Repository
rP Phabricator
Branch
focus8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16996
Build 22723: Run Core Tests
Build 22722: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 16 2017, 3:12 PM
This revision was automatically updated to reflect the committed changes.