Page MenuHomePhabricator
Differential D17906

Add Differential keyboard shortcuts for "mark done" and "hide/show"
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 6:19 PM
Unknown Object (File)
Sun, Feb 9, 4:05 AM
Unknown Object (File)
Sun, Feb 9, 4:05 AM
Unknown Object (File)
Sun, Feb 9, 4:05 AM
Unknown Object (File)
Fri, Jan 31, 7:32 PM
Unknown Object (File)
Sat, Jan 25, 10:10 PM
Unknown Object (File)
Sat, Jan 25, 5:32 PM
Unknown Object (File)
Fri, Jan 24, 9:00 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8130: Keyboard shortcut for "Done"
Commits
rP1b5a276a02d6: Add Differential keyboard shortcuts for "mark done" and "hide/show"
Summary

Fixes T8130. Allows selected comments to be shown/hidden (with "q") or marked done/not-done (with "w").

(These key selections are because "qwer" are right next to each other on QWERTY keyboards, and now mean "hide, done, edit, reply".)

Also, allow "N" and "P" to do next/previous inline, including hidden inlines. This makes "q" to hide/show a little more powerful and a little easier to undo.

Test Plan

Used "q", "w", "N" and "P" to navigate and interact with comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 16 2017, 3:07 PM
Harbormaster completed remote builds in B16996: Diff 43068.May 16 2017, 3:08 PM
chad accepted this revision.May 16 2017, 3:12 PM
This revision is now accepted and ready to land.May 16 2017, 3:12 PM
Closed by commit rP1b5a276a02d6: Add Differential keyboard shortcuts for "mark done" and "hide/show" (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 3:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
src/
applications/
differential/
view/
15 lines
webroot/
rsrc/
js/
application/
diff/
71 lines
24 lines

Diff 43076

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility