Page MenuHomePhabricator

Add Differential keyboard shortcuts for "mark done" and "hide/show"
ClosedPublic

Authored by epriestley on May 16 2017, 3:07 PM.
Tags
None
Referenced Files
F18877051: D17906.diff
Nov 6 2025, 5:39 AM
F18779855: D17906.id.diff
Oct 11 2025, 3:37 PM
F18679202: D17906.id.diff
Sep 26 2025, 12:34 AM
F18627510: D17906.diff
Sep 16 2025, 4:11 AM
F18094551: D17906.id43076.diff
Aug 7 2025, 10:12 PM
F18087032: D17906.id43068.diff
Aug 6 2025, 1:58 AM
F17989397: D17906.id.diff
Aug 1 2025, 11:45 PM
F17941998: D17906.diff
Jul 31 2025, 6:08 AM
Subscribers
None

Details

Summary

Fixes T8130. Allows selected comments to be shown/hidden (with "q") or marked done/not-done (with "w").

(These key selections are because "qwer" are right next to each other on QWERTY keyboards, and now mean "hide, done, edit, reply".)

Also, allow "N" and "P" to do next/previous inline, including hidden inlines. This makes "q" to hide/show a little more powerful and a little easier to undo.

Test Plan

Used "q", "w", "N" and "P" to navigate and interact with comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 16 2017, 3:12 PM
This revision was automatically updated to reflect the committed changes.