Page MenuHomePhabricator
Differential D17895

Restore the Differential "edit" and "reply" keyboard shortcuts
ClosedPublic
Actions

Authored by epriestley on May 16 2017, 12:33 AM.
Tags
None
Referenced Files
F18055004: D17895.diff
Mon, Aug 4, 6:56 AM
F17883544: D17895.id43056.diff
Mon, Jul 28, 11:22 PM
F17850339: D17895.id.diff
Sun, Jul 27, 9:51 AM
Unknown Object (File)
Jun 8 2025, 4:14 AM
Unknown Object (File)
Jun 5 2025, 10:30 AM
Unknown Object (File)
Jun 1 2025, 7:56 PM
Unknown Object (File)
May 28 2025, 7:15 PM
Unknown Object (File)
May 7 2025, 2:50 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12616: Modernize display code for inline comments
Commits
rP2fb1edfeb198: Restore the Differential "edit" and "reply" keyboard shortcuts
Summary

Ref T12616. This makes "edit" and "reply" work again.

Test Plan

Used "e" and "r" to edit and reply.

Also used them in bogus ways and got useful UI feedback.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
48 lines
src/
applications/
differential/
view/
8 lines
webroot/
rsrc/
js/
application/
diff/
9 lines
55 lines
25 lines

Diff 43056

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility