The ports over a similar "profile image" menu item to Projects. It gives us some room to use the project icon in the sidenav along with a larger photo. It also will open up some room in the sub-page headers for us to focus on that page, and not the identity of the project at hand. Expect a few more project related touch up diffs.
Details
Details
- Reviewers
epriestley amckinley - Commits
- rPe1a97616cb3a: Add a large profile picture to Projects
Review new projects menu on a few projects, update the image, see new image. Great for team photos.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I could imagine this possibly being a net negative change like this:
- ~95% of projects never get a custom image, since Customer Impact, Differential, Diffusion, etc., don't lend themselves to images, much less #backend_server or XYZ (Milestone 6) or whatever.
- So maybe we get a big blob of wasted scree real-estate that doesn't differentiate anything in the vast majority of cases?
Comment Actions
I can reasonably make it hidable, but yes for more "tag" like usage, it's not very interesting.
Comment Actions
So maybe we get a big blob of wasted scree real-estate that doesn't differentiate anything in the vast majority of cases?
UX wise I'm not concerned with this in practice. I think it pushing the links down the page a little is better ergonomiconally, I haven't seen a project page "loaded" with links that they'd be pushed under the fold so I don't think that will be an issue, and personally I prefer a large hit area for "home" - it's generally more satisfying for me. It is slightly awkward I think for milestones and workboards, but I have more plans to clean that UI up with additional diffs.