Update Legalpad for EditEngine
ClosedPublic
Actions

Authored by chad on May 10 2017, 12:33 AM.

Details

Reviewers

epriestley

Commits

rPb32a00dbace4: Update Legalpad for EditEngine

Summary

Updates Legalpad to use EditEngine, paving the way for transaction comments. Spooky.

Test Plan

New Document
- Require signing, Corp - see fail
- Require signing, Noone - see fail
- Require signing, Ind - get asked to sign
Edit Document

Diff Detail

Repository

rP Phabricator

Branch

legalpad-edit-engine (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16892
Build 22564: Run Core Tests
Build 22563: arc lint + arc unit

Event Timeline

chad created this revision.May 10 2017, 12:33 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 10 2017, 12:33 AM

Harbormaster completed remote builds in B16882: Diff 42956.May 10 2017, 12:34 AM

The best way to do the "transaction X depends on transaction Y" stuff is currently Editor->validateAllTransactions(), PhabricatorCalendarEventEditor has an example. Rest of this looks good.

src/applications/legalpad/application/PhabricatorLegalpadApplication.php
58–59	Can we nuke this route now?

This revision now requires changes to proceed.May 10 2017, 3:27 PM

add final transaction validations

Harbormaster completed remote builds in B16892: Diff 42966.May 10 2017, 9:10 PM

chad edited the summary of this revision. (Show Details)May 10 2017, 9:18 PM

chad edited the test plan for this revision. (Show Details)

epriestley accepted this revision.May 10 2017, 9:56 PM

epriestley added inline comments.

src/applications/legalpad/editor/LegalpadDocumentEditEngine.php
108–126	(Weird indentation?)
src/applications/legalpad/xaction/LegalpadDocumentRequireSignatureTransaction.php
61	Probably "invaliderror" is a better fit here.