Paths

Table of Contentst

Differential D17862

Update Legalpad for EditEngine
ClosedPublic
Actions

Authored by chad on May 10 2017, 12:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 7, 12:39 AM

	Unknown Object (File)
	Fri, Jan 3, 2:46 AM

	Unknown Object (File)
	Mon, Dec 30, 9:51 PM

	Unknown Object (File)
	Wed, Dec 25, 8:08 AM

	Unknown Object (File)
	Tue, Dec 17, 7:43 AM

	Unknown Object (File)
	Tue, Dec 17, 6:31 AM

	Unknown Object (File)
	Mon, Dec 16, 7:59 PM

	Unknown Object (File)
	Sun, Dec 15, 11:19 AM

Subscribers

Details

Reviewers

Commits

rPb32a00dbace4: Update Legalpad for EditEngine

Summary

Updates Legalpad to use EditEngine, paving the way for transaction comments. Spooky.

Test Plan

New Document
- Require signing, Corp - see fail
- Require signing, Noone - see fail
- Require signing, Ind - get asked to sign
Edit Document

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 10 2017, 12:33 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 10 2017, 12:33 AM

Harbormaster completed remote builds in B16882: Diff 42956.May 10 2017, 12:34 AM

The best way to do the "transaction X depends on transaction Y" stuff is currently Editor->validateAllTransactions(), PhabricatorCalendarEventEditor has an example. Rest of this looks good.

src/applications/legalpad/application/PhabricatorLegalpadApplication.php
58–59	Can we nuke this route now?

This revision now requires changes to proceed.May 10 2017, 3:27 PM

add final transaction validations

Harbormaster completed remote builds in B16892: Diff 42966.May 10 2017, 9:10 PM

chad edited the summary of this revision. (Show Details)May 10 2017, 9:18 PM

chad edited the test plan for this revision. (Show Details)

epriestley accepted this revision.May 10 2017, 9:56 PM

epriestley added inline comments.

src/applications/legalpad/editor/LegalpadDocumentEditEngine.php
109–127	(Weird indentation?)
src/applications/legalpad/xaction/LegalpadDocumentRequireSignatureTransaction.php
61	Probably "invaliderror" is a better fit here.

This revision is now accepted and ready to land.May 10 2017, 9:56 PM

Closed by commit rPb32a00dbace4: Update Legalpad for EditEngine (authored by chad, committed by chad). · Explain WhyMay 10 2017, 10:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

legalpad/

application/

PhabricatorLegalpadApplication.php

7 lines

controller/

LegalpadController.php

2 lines

LegalpadDocumentEditController.php

272 lines

LegalpadDocumentListController.php

2 lines

editor/

LegalpadDocumentEditEngine.php

169 lines

LegalpadDocumentEditor.php

39 lines

storage/

LegalpadDocument.php

4 lines

xaction/

LegalpadDocumentRequireSignatureTransaction.php

18 lines

Diff 42970

src/__phutil_library_map__.php

Loading...

src/applications/legalpad/application/PhabricatorLegalpadApplication.php

Loading...

src/applications/legalpad/controller/LegalpadController.php

Loading...

src/applications/legalpad/controller/LegalpadDocumentEditController.php

Loading...

src/applications/legalpad/controller/LegalpadDocumentListController.php

Loading...

src/applications/legalpad/editor/LegalpadDocumentEditEngine.php

Loading...

src/applications/legalpad/editor/LegalpadDocumentEditor.php

Loading...

src/applications/legalpad/storage/LegalpadDocument.php

Loading...

src/applications/legalpad/xaction/LegalpadDocumentRequireSignatureTransaction.php

Loading...