Page MenuHomePhabricator

Clean up some rough Macro transaction edges
ClosedPublic

Authored by chad on May 8 2017, 8:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 11:48 PM
Unknown Object (File)
Feb 20 2024, 1:10 PM
Unknown Object (File)
Feb 20 2024, 10:26 AM
Unknown Object (File)
Feb 8 2024, 11:44 AM
Unknown Object (File)
Feb 7 2024, 3:57 PM
Unknown Object (File)
Feb 5 2024, 10:22 AM
Unknown Object (File)
Feb 4 2024, 7:16 AM
Unknown Object (File)
Jan 29 2024, 11:54 AM
Subscribers

Details

Summary

Ref T12685, cleans up various macro issues, remove subscribers, fix feed stories, etc.

Test Plan

Create a new macro, see no subscribers, edit various macros.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • fix edit with no macro?

One inline I'm not sure about, looks good otherwise.

src/applications/macro/editor/PhabricatorMacroEditEngine.php
75–76

GREAT comment A+++

src/applications/macro/xaction/PhabricatorMacroFileTransaction.php
13–14

What's this one for?

src/applications/macro/xaction/PhabricatorMacroFileTransaction.php
13–14

Editing a macro without changing the file generates an empty transaction instead of no transaction.

13–14

Specifically, it tries to set null, and the column isn't nullable.

Let me see if I can make FileEditField or whatever it is a little smarter about things.

If you put this on top of D17853, I think you can delete that if ($value) { bit and everything will just work better (not perfectly, but better).

This revision is now accepted and ready to land.May 8 2017, 11:28 PM
This revision was automatically updated to reflect the committed changes.