I think this should (at least mostly) work on its own -- at least in Differential, we were able to do the conversion piecemeal without moving every transactiontype over at once. Maybe you could do something similar here? Like do all the simple title/description stuff and then we can do the workboard things separately? Or are you hitting more complicated issues?

I'm stuck at "Capability Not Supported" when just creating a random task. Haven't been able to track down which transaction is causing it.

I added this:

diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
index b5aa399521..6412ac6817 100644
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -404,6 +404,7 @@ abstract class PhabricatorApplicationTransactionEditor
       case PhabricatorTransactions::TYPE_COMMENT:
         return null;
       default:
+        var_dump($type);
         return $this->getCustomTransactionOldValue($object, $xaction);
     }
   }

...and got core:columns dumped. I think the issue is that ManiphestTransactionEditor-> getCustomTransactionOldValue() was removed completely, but a couple of the transaction types haven't converted yet. You could either convert them (maybe tricky) or put it back with just return null for those couple of types (maybe easier).

I do think this all reasonably works, but I haven't tested email commands, herald... will keep testing.

I'm being lazy about looking at this until after the release cut. Zzz

oh wow there's an emoji! 💤

Don't even trip. You got this.

Not sure how to test the parent transaction validation stuff. I set a bunch of parents, subtasks, changed lots of orders....

The easiest way to test if the code is running is to add throw new Exception("Yep, this code is running.") above the validation and see if it gets hit.

To test that the code actually works, the easiest thing is probably to call maniphest.edit with a bad parent (like "cat"), probably something like:

$ echo '{
  "transactions": [
    {
      "type": "parent",
      "value": "cat"
    },
    {
      "type": "title",
      "value": "test"
    }
  ]
}' | arc call-conduit maniphest.edit --conduit-uri http://local.phacility.com/
{"error":"ERR-CONDUIT-CORE","errorMessage":"ERR-CONDUIT-CORE: Validation errors:\n  - Parent task identifier \"cat\" does not identify a visible task.","response":null}

Host returned HTTP/200, but invalid JSON data in response to a Conduit method call. {>} (PhutilJSONParserException)

Check for junk in your error log, or make the call from the web UI? I can apply + poke if that doesn't reveal anything.

derp, forgot to check error log

EXCEPTION: (Error) Call to a member function getIsCreateTransaction() on null

I see this a lot where I want to validate something on creation, but seems like it not supported. Should I move this into a validateAllTransactions check up in Editor?

{"error":"ERR-CONDUIT-CORE","errorMessage":"ERR-CONDUIT-CORE: Validation errors:\n - Parent task identifier \"cat\" does not identify a visible task.","response":null}

Purrrrrfect.