Page MenuHomePhabricator

Allow ApplicationTransactionEditor to figure out whether TYPE_COMMENT is supported or not
ClosedPublic

Authored by epriestley on May 3 2017, 5:43 PM.
Tags
None
Referenced Files
F17921987: D17822.id.diff
Wed, Jul 30, 6:08 AM
F17893538: D17822.diff
Tue, Jul 29, 5:08 AM
Unknown Object (File)
Jun 26 2025, 10:35 AM
Unknown Object (File)
Jun 21 2025, 12:05 PM
Unknown Object (File)
Jun 19 2025, 5:13 AM
Unknown Object (File)
Apr 12 2025, 9:40 AM
Unknown Object (File)
Apr 10 2025, 11:25 PM
Unknown Object (File)
Apr 8 2025, 3:46 AM
Subscribers
None

Details

Summary

See D17812, etc. We can figure this out by looking at the object carefully. We don't need to go delete all the old TYPE_COMMENT (it doesn't hurt anything) but can nuke it when we see it.

Test Plan
  • Made a comment in Slowvote (supports commenting).
  • Viewed an Almanac device (does not support commenting).

Diff Detail

Repository
rP Phabricator
Branch
comment1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16777
Build 22387: Run Core Tests
Build 22386: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 3 2017, 5:48 PM

Macro diff assumes this will land

This revision was automatically updated to reflect the committed changes.