Page MenuHomePhabricator
Differential D17789

Fix legalpad error display
ClosedPublic
Actions

Authored by chad on Apr 25 2017, 4:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 25, 2:56 AM
Unknown Object (File)
Wed, Dec 18, 6:49 PM
Unknown Object (File)
Fri, Dec 13, 8:48 PM
Unknown Object (File)
Thu, Dec 12, 8:35 PM
Unknown Object (File)
Nov 30 2024, 4:36 PM
Unknown Object (File)
Nov 25 2024, 11:59 AM
Unknown Object (File)
Nov 24 2024, 5:44 AM
Unknown Object (File)
Nov 22 2024, 8:45 PM
View All 97 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12636: Legalpad error view is missing some margins/padding
Commits
rP9509bd1c7f2e: Fix legalpad error display
Summary

Fixes T12636.

Test Plan

Make a from, submit signature without checking box, see correctly aligned error.

Diff Detail

Repository
rP Phabricator
Branch
legalpad (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16701
Build 22277: Run Core Tests
Build 22276: arc lint + arc unit

Event Timeline

chad created this revision.Apr 25 2017, 4:26 PM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 25 2017, 4:26 PM
epriestley accepted this revision.Apr 25 2017, 4:27 PM
This revision is now accepted and ready to land.Apr 25 2017, 4:27 PM
Harbormaster completed remote builds in B16701: Diff 42774.Apr 25 2017, 4:27 PM
Closed by commit rP9509bd1c7f2e: Fix legalpad error display (authored by chad, committed by chad). · Explain WhyApr 25 2017, 4:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
legalpad/
controller/
5 lines

Diff 42774

View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
Phabricator · Built by Phacility