Page MenuHomePhabricator

Detect unsynchronizable repositories on multiple cluster hosts
ClosedPublic

Authored by epriestley on Apr 23 2017, 1:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 23 2024, 11:58 AM
Unknown Object (File)
Oct 9 2024, 3:46 PM
Unknown Object (File)
Sep 6 2024, 12:08 AM
Unknown Object (File)
Sep 4 2024, 8:23 PM
Unknown Object (File)
Sep 3 2024, 11:25 AM
Unknown Object (File)
Aug 31 2024, 3:34 AM
Unknown Object (File)
Aug 20 2024, 3:32 PM
Unknown Object (File)
Aug 20 2024, 2:40 PM
Subscribers
None

Details

Summary

Ref T12613. Currently, the SVNTEST and HGTEST repositories are improperly configured on secure. These repositories use VCS systems which do not support synchronization, so they can not be served from cluster services with multiple hosts.

However, I've incorrectly configured them the same way as all the Git repositories, which support synchronization. This causes about 50% of requests to randomly fail (when they reach the wrong host).

Detect this issue and warn the user that the configuration is not valid.

It should be exceptionally difficult for normal installs to run into this.

Test Plan
  • Mostly faked these conditions locally, verified that secure really has this configuration.
  • I'll push this, verify that the issue is detected correctly in production, then fix the config which should resolve the intermittent issues with SVNTEST.

Diff Detail

Repository
rP Phabricator
Branch
svn1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/repository/storage/PhabricatorRepository.php:1949XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 16666
Build 22228: Run Core Tests
Build 22227: arc lint + arc unit