Page MenuHomePhabricator
Differential D17764

Fix fatal in Conpherence NUX state
ClosedPublic
Actions

Authored by epriestley on Apr 21 2017, 9:47 PM.
Tags
None
Referenced Files
F14118504: D17764.diff
Fri, Nov 29, 12:13 AM
Unknown Object (File)
Mon, Nov 25, 6:23 AM
Unknown Object (File)
Sat, Nov 23, 6:01 PM
Unknown Object (File)
Wed, Nov 20, 7:12 PM
Unknown Object (File)
Sun, Nov 17, 4:53 AM
Unknown Object (File)
Wed, Nov 6, 9:51 PM
Unknown Object (File)
Oct 29 2024, 7:11 PM
Unknown Object (File)
Oct 15 2024, 7:50 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12619: Conpherence fatals on a fresh install
Commits
rP03d0e3fdbc89: Fix fatal in Conpherence NUX state
Summary

Fixes T12619.

Test Plan

Faked return array() in ConpherneceThreadQuery, got a NUX instead of fatal.

Diff Detail

Repository
rP Phabricator
Branch
cnux1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16645
Build 22196: Run Core Tests
Build 22195: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 21 2017, 9:47 PM
Harbormaster completed remote builds in B16645: Diff 42717.Apr 21 2017, 9:49 PM
chad accepted this revision.Apr 21 2017, 9:50 PM
This revision is now accepted and ready to land.Apr 21 2017, 9:50 PM
epriestley added a comment.Apr 21 2017, 9:50 PM

The internet points are all MINE!

Closed by commit rP03d0e3fdbc89: Fix fatal in Conpherence NUX state (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2017, 9:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
controller/
15 lines

Diff 42717

View Options

src/applications/conpherence/controller/ConpherenceListController.php

Loading...
Phabricator · Built by Phacility