Allow users to choo choo choose a room color
ClosedPublic
Actions

Authored by chad on Apr 20 2017, 9:22 PM.

Details

Reviewers

Commits

rPed9afa18cca5: Allow users to choo choo choose a room color

Summary

This adds some basic per user / per room theming for Conpherence, which should hopefully let users identify rooms from just the sidebar color.

Test Plan

Lots of threads with different colors.

Diff Detail

Repository

rP Phabricator

Branch

conph-colors (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16618
Build 22159: Run Core Tests
Build 22158: arc lint + arc unit

Event Timeline

chad created this revision.Apr 20 2017, 9:22 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 20 2017, 9:22 PM

this was not an hour's work

Harbormaster completed remote builds in B16617: Diff 42686.Apr 20 2017, 9:23 PM

unrelated

Harbormaster completed remote builds in B16618: Diff 42687.Apr 20 2017, 9:25 PM

Seems slightly odd that this is per-user/per-room instead of per-room or "per user, but with a per-room default". How will users fight over whether a room should be peach or indigo?

This revision is now accepted and ready to land.Apr 20 2017, 9:26 PM

I think users who want one color (like a color blind or dark theme) can set their default, or the other use case is identifying rooms visually (so you don't leak private data), which still seems up to the user.

I can't think of any reason room admins would want to set a specific color, other than to add to arguments, like you suggest.

Or you're trolling me.

Closed by commit rPed9afa18cca5: Allow users to choo choo choose a room color (authored by chad, committed by chad). · Explain WhyApr 20 2017, 9:31 PM

This revision was automatically updated to reflect the committed changes.

I'm only half-trolling. Maybe I want to make "Security Red Team" red, or "Buy/Sell" green. Or we let you set custom images and "Dog Lovers" wants to set dog wallpaper.