When a package or project has been accepted or rejected, show who did it ("Accepted (by dog)")
ClosedPublic
Actions

Authored by epriestley on Apr 19 2017, 11:37 PM.

Tags

None

Referenced Files

	F13127200: D17741.diff
	Tue, Apr 30, 5:50 PM

	Unknown Object (File)
	Mon, Apr 29, 2:13 PM

	Unknown Object (File)
	Wed, Apr 24, 10:16 PM

	Unknown Object (File)
	Thu, Apr 11, 7:33 AM

	Unknown Object (File)
	Tue, Apr 2, 4:50 AM

	Unknown Object (File)
	Sun, Mar 31, 11:07 PM

	Unknown Object (File)
	Mar 4 2024, 6:56 PM

	Unknown Object (File)
	Feb 26 2024, 9:07 PM

View All 88 Files

Subscribers

None

Details

Reviewers

chad

Commits

rP7a992b548898: When a package or project has been accepted or rejected, show who did it…

Summary

Makes it more clear whose authority actions have been taken under.

Test Plan

Screen Shot 2017-04-19 at 4.33.02 PM.png (204×516 px, 25 KB)

Diff Detail

Repository

rP Phabricator

Branch

reviewer1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16607
Build 22144: Run Core Tests
Build 22143: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 19 2017, 11:37 PM

epriestley added inline comments.Apr 19 2017, 11:37 PM

src/applications/base/PhabricatorApplication.php
646	This just makes lint stop complaining until we sort this out for T11476.

Harbormaster completed remote builds in B16607: Diff 42672.Apr 19 2017, 11:38 PM

chad accepted this revision.Apr 20 2017, 5:28 PM

This revision is now accepted and ready to land.Apr 20 2017, 5:28 PM

Closed by commit rP7a992b548898: When a package or project has been accepted or rejected, show who did it… (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2017, 8:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

PhabricatorApplication.php

2 lines

differential/

view/

DifferentialReviewersView.php

101 lines

Diff 42672

View Options

src/applications/base/PhabricatorApplication.php