Page MenuHomePhabricator
Differential D17721

Play a sound when receiving a new chat message
ClosedPublic
Actions

Authored by epriestley on Apr 18 2017, 4:37 PM.
Tags
None
Referenced Files
F15471332: D17721.diff
Sat, Apr 5, 4:35 AM
F15448533: D17721.id42624.diff
Fri, Mar 28, 5:28 AM
F15442215: D17721.id.diff
Wed, Mar 26, 10:12 PM
F15435665: D17721.id42617.diff
Tue, Mar 25, 9:37 AM
F15426515: D17721.id42624.diff
Sun, Mar 23, 9:17 AM
F15415264: D17721.id.diff
Thu, Mar 20, 5:05 AM
F15414725: D17721.id42617.diff
Thu, Mar 20, 2:09 AM
F15414724: D17721.id42624.diff
Thu, Mar 20, 2:09 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7567: Support sound in Conpherence
Commits
rP5d55804e3fa6: Play a sound when receiving a new chat message
Summary

Ref T7567. Nothing fancy yet, just getting this working. Sound is lightly edited version of "Pop 6":

https://www.freesound.org/people/greenvwbeetle/sounds/244656/

Test Plan

Sent chat, heard sounds.

Diff Detail

Repository
rP Phabricator
Branch
sound1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16551
Build 22057: Run Core Tests
Build 22056: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 18 2017, 4:37 PM
Harbormaster completed remote builds in B16551: Diff 42617.Apr 18 2017, 4:39 PM
chad accepted this revision.Apr 18 2017, 5:03 PM
This revision is now accepted and ready to land.Apr 18 2017, 5:03 PM
Closed by commit rP5d55804e3fa6: Play a sound when receiving a new chat message (authored by epriestley, committed by epriestley). · Explain WhyApr 18 2017, 6:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
30 lines
1 line
src/
applications/
conpherence/
controller/
6 lines
webroot/
rsrc/
audio/
basic/
js/
application/
conpherence/
8 lines

Diff 42617

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

webroot/rsrc/audio/basic/tap.mp3

Loading...
View Options

webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js

Loading...
Phabricator · Built by Phacility