Page MenuHomePhabricator

When a transaction has no quote ref, render "@user wrote:" properly
ClosedPublic

Authored by epriestley on Apr 18 2017, 4:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 2, 4:44 AM
Unknown Object (File)
Jan 9 2024, 11:18 PM
Unknown Object (File)
Dec 26 2023, 1:58 AM
Unknown Object (File)
Dec 20 2023, 4:28 PM
Unknown Object (File)
Dec 19 2023, 4:35 PM
Unknown Object (File)
Nov 30 2023, 5:13 AM
Unknown Object (File)
Nov 27 2023, 10:41 AM
Unknown Object (File)
Nov 18 2023, 9:53 AM
Subscribers
None

Details

Summary

Fixes T12576. In Javascript, data.ref is null, which is getting turned into /quote/?ref=null.

The code already handles this case, just not with ref=null happening in JS:

https://secure.phabricator.com/source/phabricator/browse/master/src/applications/transactions/controller/PhabricatorApplicationTransactionCommentQuoteController.php;b54adc6161c205e146fabb801ca53a44d94da444$47-52

Test Plan

Screen Shot 2017-04-18 at 9.04.32 AM.png (173×411 px, 11 KB)

  • Also quoted a normal comment on a normal object in a normal way.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable