Fixes T12556 Uses more common components in ConpherenceThreadList by moving to PHUIListItemView. Reduces clutter by moving privacy into the header. Gets ride of "See More" double interchanges.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12556: Move privacy to room header
- Commits
- rP2d00f5683786: Use PHUIListItemView in ConpherenceThreadList
I need to test this more, doesn't seem to auto-select top room any more, also might build a lipsum generator.
- Create lots of rooms with various policies
- Test clicking on policy object
- Click on different rooms
- Post in rooms
- Load up second account, see room numbers
- Clear room message count by clicking on room
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phui-list-item-count (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16507 Build 21987: Run Core Tests Build 21986: arc lint + arc unit
Event Timeline
Comment Actions
These things don't work for me and/or also seem iffy locally:
- At /conpherence/, I also don't see the top room, just a list of rooms.
- Going to /conpherence/ and using the left nav just reloads the list, it doesn't select rooms.
- Stuff does work if I click to a particular room first, then navigate.
Miscellaneous stuff:
- "Topic • Policies" is a little weird, I'd expect "Policies • Topic" instead? Policies is leftmost in every other application, and topic has to be truncated to keep policies onscreen with this layout?
- Maximum display topic size feels really small? Lots of unused room with the layout on my monitor.
- No way to see full topic if I can't edit the room?
- UI turns into chaos at tablet sizes:
- Search list UI still shows policy icons, maybe now somewhat inconsistent / worth revisiting?
- Would be nice for NUX to be reachable via ?nux=trueor similar, ideally with a developer link in the UI, since it's a pain to test as-is.
- I've got a bunch of T12569 locally:
- Maybe ambiguous/confusing that "See All Rooms" takes you to "Joined Rooms", not "All Rooms"? The context where the link exists may also include rooms you haven't joined, if you're looking at a visible but un-joined room. Probably clear enough and I can't really come up with better wording offhand, though.
- Happy to see "See More" go, always felt kinda weird to me.
- When I manually set SEE_ALL_LIMIT to 2, I don't actually get a "See All Rooms" link? I think this logic isn't reachable currently, see inline for possible cause.
| src/applications/conpherence/controller/ConpherenceListController.php | ||
|---|---|---|
| 37 | (Dropping the +1 here might be what's breaking the "See All Rooms" link, since only 20 results ever get loaded?) | |
| webroot/rsrc/js/application/conpherence/behavior-menu.js | ||
| 428–429 | I think this can be removed now. | |
Comment Actions
These things don't work for me and/or also seem iffy locally
Yeah I mentioned this in the test plan, I still need to figure out what I did to break this.
"Topic • Policies" is a little weird, I'd expect "Policies • Topic" instead? Policies is leftmost in every other application, and topic has to be truncated to keep policies onscreen with this layout?
Yeah... don't have a good solution that isn't a ton of work. ie, no CSS only solution give the structure of PHUIHeaderView...
Comment Actions
- flip order of policy, topic
- auto-select first room
- minor css adjustments for widgets
- better language