Page MenuHomePhabricator

Reduce code duplication in Phortune account controllers
ClosedPublic

Authored by epriestley on Apr 14 2017, 5:17 PM.
Tags
None
Referenced Files
F18787646: D17694.id.diff
Wed, Oct 15, 12:42 AM
F18777403: D17694.id42554.diff
Sat, Oct 11, 2:41 AM
F18777099: D17694.id42548.diff
Sat, Oct 11, 12:54 AM
F18770698: D17694.id.diff
Wed, Oct 8, 2:19 PM
F18764204: D17694.diff
Tue, Oct 7, 4:47 AM
F18748803: D17694.diff
Sat, Oct 4, 12:50 AM
F18716387: D17694.id42548.diff
Mon, Sep 29, 11:52 AM
F18580433: D17694.id42554.diff
Sep 11 2025, 3:17 AM
Subscribers
None

Details

Summary

Ref T12451. This is a GREAT comment (A++) but we only need one copy of it.

This uses a pattern similar to Projects, which is a little weird but works well enough.

Test Plan
  • Viewed all four tabs of an account.
  • Viewed a page with a bad account ID which 404'd properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 14 2017, 5:20 PM
This revision was automatically updated to reflect the committed changes.