Page MenuHomePhabricator
Differential D17694

Reduce code duplication in Phortune account controllers
ClosedPublic
Actions

Authored by epriestley on Apr 14 2017, 5:17 PM.
Tags
None
Referenced Files
F19027616: D17694.id.diff
Mon, Nov 24, 2:12 PM
F19016660: D17694.diff
Sun, Nov 23, 4:56 AM
F18984911: D17694.id.diff
Mon, Nov 17, 12:48 PM
F18901145: D17694.id42554.diff
Fri, Nov 7, 9:40 PM
F18901144: D17694.id42548.diff
Fri, Nov 7, 9:40 PM
F18901142: D17694.id.diff
Fri, Nov 7, 9:40 PM
F18870759: D17694.id42554.diff
Tue, Nov 4, 6:48 PM
F18854667: D17694.diff
Sat, Nov 1, 12:26 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12451: Finding your subscriptions / cards on Phacility is non-obvious
Commits
rPaec19d2acf32: Reduce code duplication in Phortune account controllers
Summary

Ref T12451. This is a GREAT comment (A++) but we only need one copy of it.

This uses a pattern similar to Projects, which is a little weird but works well enough.

Test Plan
  • Viewed all four tabs of an account.
  • Viewed a page with a bad account ID which 404'd properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 14 2017, 5:17 PM
Harbormaster completed remote builds in B16479: Diff 42548.Apr 14 2017, 5:17 PM
Harbormaster completed remote builds in B16479: Diff 42548.
chad accepted this revision.Apr 14 2017, 5:20 PM

but... pasta...

This revision is now accepted and ready to land.Apr 14 2017, 5:20 PM
Closed by commit rPaec19d2acf32: Reduce code duplication in Phortune account controllers (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2017, 5:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42554

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountBillingController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountManagerController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountProfileController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountViewController.php

Loading...
Phabricator · Built by Phacility