Page MenuHomePhabricator
Differential D17694

Reduce code duplication in Phortune account controllers
ClosedPublic
Actions

Authored by epriestley on Apr 14 2017, 5:17 PM.
Tags
None
Referenced Files
F15462644: D17694.id42554.diff
Tue, Apr 1, 4:28 PM
F15461553: D17694.diff
Tue, Apr 1, 9:12 AM
F15425164: D17694.id42548.diff
Sun, Mar 23, 2:53 AM
F15417914: D17694.id42554.diff
Thu, Mar 20, 7:25 PM
F15417784: D17694.id.diff
Thu, Mar 20, 6:31 PM
F15416446: D17694.id42548.diff
Thu, Mar 20, 11:08 AM
F15412908: D17694.id.diff
Wed, Mar 19, 3:42 PM
F15403978: D17694.diff
Tue, Mar 18, 5:47 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12451: Finding your subscriptions / cards on Phacility is non-obvious
Commits
rPaec19d2acf32: Reduce code duplication in Phortune account controllers
Summary

Ref T12451. This is a GREAT comment (A++) but we only need one copy of it.

This uses a pattern similar to Projects, which is a little weird but works well enough.

Test Plan
  • Viewed all four tabs of an account.
  • Viewed a page with a bad account ID which 404'd properly.

Diff Detail

Repository
rP Phabricator
Branch
phortune6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/phortune/controller/account/PhortuneAccountController.php:24XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 16479
Build 21944: Run Core Tests
Build 21943: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 14 2017, 5:17 PM
Harbormaster completed remote builds in B16479: Diff 42548.Apr 14 2017, 5:17 PM
Harbormaster completed remote builds in B16479: Diff 42548.
chad accepted this revision.Apr 14 2017, 5:20 PM

but... pasta...

This revision is now accepted and ready to land.Apr 14 2017, 5:20 PM
Closed by commit rPaec19d2acf32: Reduce code duplication in Phortune account controllers (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2017, 5:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42548

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountBillingController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountManagerController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountProfileController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php

Loading...
View Options

src/applications/phortune/controller/account/PhortuneAccountViewController.php

Loading...
Phabricator · Built by Phacility