Does a few things. Turns off feed stories (again), removes "action" transactions from notificiations, and only updates message count on actual messages. This feels a bit cleaner and less spammy... I guess... I think @epriestley will really like it and do me a favor or something.
Details
Details
Pull up two windows. test a message, see message count on second screen. Edit a topic or title, get no notification. At all. Ever.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- conph-notifications (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16438 Build 21875: Run Core Tests Build 21874: arc lint + arc unit
Event Timeline
Comment Actions
These feel weird to me not because they feel spammy, but because they're putting super private information in feed most of the time. Like 95% of the time when I see a Conpherence-related story in feed it's about a private room, and they're super rare, so I'm like "are policies screwed up?". Also weird to send a private message to one other person talking about a coworker behind their back and have it show up in feed immediately (although I think the removal of "first message" eliminates this):
This isn't really a problem unique to Conpherence, but I think with other types of stories they're common and most of them are public so it doesn't feel as weird.
These stories also just aren't very useful, since everyone who can see them (at least, the "new room" ones) gets a Conpherence notification anyway.
| src/applications/conpherence/controller/ConpherenceNotificationPanelController.php | ||
|---|---|---|
| 23 | (What's the reasoning on this?) | |
| src/applications/conpherence/controller/ConpherenceNotificationPanelController.php | ||
|---|---|---|
| 23 | We batch 100 latest transactions, then loop to see which have a message. If you have 1 active thread and 4 really old threads, we don't have a message to show you. This is legacy stuff, I think maybe the right fix is to have a cache for "last-message" so it always gets filled. | |