Begin converting Conpherence to ModularTransactions, this converts title, topic, and picture to use modular transactions. Participants seems hairy so I'll do that in another diff
Details
Details
- Reviewers
epriestley - Commits
- rPa7ebfc12c025: Modernize Conpherence with Modular Transactions
Create a room with a topic, change room name, topic. Add people, remove people. Set a room image. Unset topic.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- conpherence-xaction (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16422 Build 21850: Run Core Tests Build 21849: arc lint + arc unit
Event Timeline
| src/applications/conpherence/editor/ConpherenceEditor.php | ||
|---|---|---|
| 36 | We'll want a getObjectCreateString() or whatever it is here, for "%s created this room.", although we won't actually start hitting it until we convert to EditEngine. | |
| 544–559 | This means that we'll never publish Conpherence feed stories. I think that's actually good since they always seem weird to me, but wanted to make sure it's intentional. | |