Page MenuHomePhabricator

Modernize Conpherence with Modular Transactions
ClosedPublic

Authored by chad on Apr 12 2017, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 12:38 AM
Unknown Object (File)
Sat, Nov 16, 5:40 PM
Unknown Object (File)
Oct 21 2024, 11:24 PM
Unknown Object (File)
Oct 14 2024, 3:18 PM
Unknown Object (File)
Sep 9 2024, 2:56 PM
Unknown Object (File)
Aug 29 2024, 11:03 AM
Unknown Object (File)
Aug 27 2024, 9:33 PM
Unknown Object (File)
Aug 26 2024, 12:21 PM
Subscribers

Details

Summary

Begin converting Conpherence to ModularTransactions, this converts title, topic, and picture to use modular transactions. Participants seems hairy so I'll do that in another diff

Test Plan

Create a room with a topic, change room name, topic. Add people, remove people. Set a room image. Unset topic.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley added inline comments.
src/applications/conpherence/editor/ConpherenceEditor.php
36

We'll want a getObjectCreateString() or whatever it is here, for "%s created this room.", although we won't actually start hitting it until we convert to EditEngine.

544–559

This means that we'll never publish Conpherence feed stories. I think that's actually good since they always seem weird to me, but wanted to make sure it's intentional.

This revision is now accepted and ready to land.Apr 12 2017, 10:07 PM

No I love feed stories. And sending emails.

This revision was automatically updated to reflect the committed changes.