Differential D17664

Check is viewer is a participant before showing count
ClosedPublic
Actions

Authored by chad on Apr 12 2017, 8:24 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T12485: Conpherence MenuItem

Commits

rP6bf595b95154: Check is viewer is a participant before showing count

Summary

In Conpherence ProfileMenuItem we show an unread count if you're a participant, but all message count if you're not. Just remove that.

Test Plan

Log out of room in Conpherence, leave messages on second account, check menu item on both accounts.

Diff Detail

Repository

rP Phabricator

Branch

conpherence-menu-list-2 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16415
Build 21839: Run Core Tests
Build 21838: arc lint + arc unit

Event Timeline

chad created this revision.Apr 12 2017, 8:24 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 12 2017, 8:24 PM

epriestley accepted this revision.Apr 12 2017, 8:25 PM

This revision is now accepted and ready to land.Apr 12 2017, 8:25 PM

Harbormaster completed remote builds in B16415: Diff 42484.Apr 12 2017, 8:25 PM

Closed by commit rP6bf595b95154: Check is viewer is a participant before showing count (authored by chad, committed by chad). · Explain WhyApr 12 2017, 8:27 PM

This revision was automatically updated to reflect the committed changes.

I now no longer need the menu in the header. 😄

chad added a task: T12485: Conpherence MenuItem.Apr 12 2017, 8:47 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

menuitem/

PhabricatorConpherenceProfileMenuItem.php

9 lines

Diff 42484

View Options

src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php

Check is viewer is a participant before showing countClosedPublicActions