Builds a Conpherence Profile Menu Item, complete with counts for the unreads. This allows pinning to home as well as swapping out thread list in Conpherence for pinning eventually.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12485: Conpherence MenuItem
- Commits
- rP75303567b389: Add a Conpherence Profile Menu Item
Add a menu item, chat in room, log into other account, see room count. Room count disappears after viewing.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- conpherence-menu-item (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16411 Build 21833: Run Core Tests Build 21832: arc lint + arc unit
Event Timeline
| src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php | ||
|---|---|---|
| 50–51 | (Do we need these both? We probably shouldn't, but can fix that eventually...) | |
| src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php | ||
|---|---|---|
| 50–51 | Oddly yes, I get a fatal otherwise, but I also will use the images when I implement this in full Conpherence. | |
Comment Actions
Also, is unread count meaningful/valid when you haven't joined a thread? It's vaguely possible it does something super broken like "slowly count every message, display 29,239", since the only other place we use it (I think?) is the menu, which only shows threads you're part of.
Comment Actions
Oh, I didn't test that. I assumed it wouldn't return anything if you weren't a participant. Will follow up.