Page MenuHomePhabricator

Render timezones in event reminder mail, and render them more nicely
ClosedPublic

Authored by epriestley on Apr 10 2017, 2:48 PM.
Tags
None
Referenced Files
F19050731: D17646.id.diff
Nov 27 2025, 9:21 PM
F19027192: D17646.diff
Nov 24 2025, 1:28 PM
F18838826: D17646.diff
Oct 27 2025, 12:54 PM
F18759046: D17646.id42440.diff
Oct 6 2025, 1:23 AM
F18751965: D17646.id.diff
Oct 4 2025, 1:31 PM
F18644251: D17646.diff
Sep 19 2025, 4:31 AM
F18612123: D17646.id.diff
Sep 14 2025, 8:49 AM
F18597813: D17646.diff
Sep 13 2025, 3:43 AM
Subscribers
None

Details

Summary

Fixes T12356.

  • In this mail, we currently render "6:00 AM". Instead, render "6:00 AM (PDT)" or similar. This is consistent with times in other modern Transaction mail.
  • Previously, we would render "UTC-7". Render "PDT" instead. For obscure zones with no known timezone abbreviation, fall back to "UTC-7".
Test Plan
  • Used bin/calendar notify --minutes X to trigger notifications, read email bodies.
  • Used this script to list all T values and checked them for sanity:
<?php

$now = new DateTime();

$locales = DateTimeZone::listIdentifiers();
foreach ($locales as $locale) {
  $zone = new DateTimeZone($locale);
  $now->setTimeZone($zone);

  printf(
    "%s (%s)\n",
    $locale,
    $now->format('T'));
}

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable