Page MenuHomePhabricator

Render timezones in event reminder mail, and render them more nicely
ClosedPublic

Authored by epriestley on Apr 10 2017, 2:48 PM.
Tags
None
Referenced Files
F18053465: D17646.id.diff
Mon, Aug 4, 5:06 AM
F18052244: D17646.id42440.diff
Mon, Aug 4, 1:57 AM
F18051656: D17646.id42433.diff
Sun, Aug 3, 11:58 PM
F18009425: D17646.id42440.diff
Sat, Aug 2, 3:27 PM
F17946693: D17646.diff
Thu, Jul 31, 2:48 PM
Unknown Object (File)
Jun 21 2025, 6:58 PM
Unknown Object (File)
May 29 2025, 9:15 AM
Unknown Object (File)
May 26 2025, 8:57 PM
Subscribers
None

Details

Summary

Fixes T12356.

  • In this mail, we currently render "6:00 AM". Instead, render "6:00 AM (PDT)" or similar. This is consistent with times in other modern Transaction mail.
  • Previously, we would render "UTC-7". Render "PDT" instead. For obscure zones with no known timezone abbreviation, fall back to "UTC-7".
Test Plan
  • Used bin/calendar notify --minutes X to trigger notifications, read email bodies.
  • Used this script to list all T values and checked them for sanity:
<?php

$now = new DateTime();

$locales = DateTimeZone::listIdentifiers();
foreach ($locales as $locale) {
  $zone = new DateTimeZone($locale);
  $now->setTimeZone($zone);

  printf(
    "%s (%s)\n",
    $locale,
    $now->format('T'));
}

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable