Page MenuHomePhabricator

Fix two issues with user Calendar event availability cache display
ClosedPublic

Authored by epriestley on Apr 10 2017, 11:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 23 2024, 8:01 AM
Unknown Object (File)
Oct 17 2024, 12:58 AM
Unknown Object (File)
Sep 30 2024, 7:12 PM
Unknown Object (File)
Sep 25 2024, 1:19 PM
Unknown Object (File)
Sep 9 2024, 11:32 PM
Unknown Object (File)
Sep 9 2024, 4:57 PM
Unknown Object (File)
Sep 9 2024, 2:38 PM
Unknown Object (File)
Sep 2 2024, 9:16 AM
Subscribers
None

Details

Summary

Ref T11816. Two minor issues:

  • We used $event, not $next_event, as the event providing the PHID for "Busy at <event name>". This rendered "Busy at <most future event>" on the profile instead of "Busy at <next upcoming event".
  • The TTL computation used the event start, not the event end, so we could end up rebuilding the cache too often for users busy at an event.
Test Plan
  • Attended an event in the near future and one later on.
  • Saw profile now say "busy at <near future event>" correctly.
  • In DarkConsole "Services" tab, no longer saw unnecessary cache refills while attending an event.

Diff Detail

Repository
rP Phabricator
Branch
cal2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16358
Build 21754: Run Core Tests
Build 21753: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 10 2017, 3:46 PM
This revision was automatically updated to reflect the committed changes.