Page MenuHomePhabricator

Fix two issues with user Calendar event availability cache display
ClosedPublic

Authored by epriestley on Apr 10 2017, 11:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 6:23 PM
Unknown Object (File)
Wed, Apr 17, 3:01 PM
Unknown Object (File)
Sun, Mar 31, 12:46 PM
Unknown Object (File)
Sun, Mar 31, 6:04 AM
Unknown Object (File)
Sun, Mar 31, 6:03 AM
Unknown Object (File)
Sun, Mar 31, 6:03 AM
Unknown Object (File)
Sat, Mar 30, 11:56 PM
Unknown Object (File)
Sat, Mar 30, 4:28 AM
Subscribers
None

Details

Summary

Ref T11816. Two minor issues:

  • We used $event, not $next_event, as the event providing the PHID for "Busy at <event name>". This rendered "Busy at <most future event>" on the profile instead of "Busy at <next upcoming event".
  • The TTL computation used the event start, not the event end, so we could end up rebuilding the cache too often for users busy at an event.
Test Plan
  • Attended an event in the near future and one later on.
  • Saw profile now say "busy at <near future event>" correctly.
  • In DarkConsole "Services" tab, no longer saw unnecessary cache refills while attending an event.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 10 2017, 3:46 PM
This revision was automatically updated to reflect the committed changes.