Page MenuHomePhabricator

Allow the PullLocal daemon to actually hibernate
ClosedPublic

Authored by epriestley on Apr 6 2017, 10:26 PM.
Tags
None
Referenced Files
F13218353: D17635.id42412.diff
Sat, May 18, 12:05 PM
F13208952: D17635.id42410.diff
Thu, May 16, 8:31 PM
F13207717: D17635.diff
Thu, May 16, 2:48 AM
F13207411: D17635.diff
Wed, May 15, 11:18 PM
F13187718: D17635.diff
Sat, May 11, 4:42 AM
Unknown Object (File)
Tue, May 7, 7:53 AM
Unknown Object (File)
Fri, May 3, 7:34 AM
Unknown Object (File)
Thu, Apr 25, 1:37 AM
Subscribers
None

Details

Summary

Ref T12298. The PullLocal daemon has had hibernation code for a little while, but it never actually activated because we don't sleep for more than 15 seconds in any case.

Add a maximum sleep instead and use that to control the longest sleep we'll do for hibernation purposes.

Also, when a repository or repository URI is edited, write a NEEDS_UPDATE event into the message table to make sure the daemons de-hibernate.

Test Plan

Used bin/phd debug pull, saw the daemon actually hibernate instead of just sleeping for 15 seconds.

Diff Detail

Repository
rP Phabricator
Branch
pull1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16338
Build 21727: Run Core Tests
Build 21726: arc lint + arc unit

Event Timeline

epriestley created this revision.
  • More authetic changeset.
This revision is now accepted and ready to land.Apr 6 2017, 10:31 PM
This revision was automatically updated to reflect the committed changes.