Page MenuHomePhabricator

Fix scope of "Accept" when you don't check all the "Force Accept" boxes
ClosedPublic

Authored by epriestley on Apr 6 2017, 9:59 PM.
Tags
None
Referenced Files
F13081002: D17634.id.diff
Wed, Apr 24, 12:46 PM
Unknown Object (File)
Sat, Apr 20, 1:19 PM
Unknown Object (File)
Sat, Apr 6, 8:45 PM
Unknown Object (File)
Wed, Apr 3, 3:39 PM
Unknown Object (File)
Sun, Mar 31, 12:31 AM
Unknown Object (File)
Fri, Mar 29, 10:00 AM
Unknown Object (File)
Feb 3 2024, 3:28 PM
Unknown Object (File)
Jan 26 2024, 1:24 AM
Subscribers
None

Details

Summary

Ref T12272. I wrote this correctly, then broke it by adding the simplification which treats "accept the defaults" as "accept everything".

This simplification lets us render "epriestley accepted this revision." instead of "epriestley accepted this revision onbehalf of: long, list, of, every, default, reviewer, they, have, authority, over." so it's a good thing, but make it only affect the reviewers it's supposed to affect.

Test Plan
  • Did an accept with a force-accept available but unchecked.
  • Before patch: incorrectly accepted all possible reviewers.
  • After patch: accepted only checked reviewers.
  • Also checked the force-accept box, accepted, got a proper force-accept.

Diff Detail

Repository
rP Phabricator
Branch
review2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16336
Build 21724: Run Core Tests
Build 21723: arc lint + arc unit