Page MenuHomePhabricator

Replace Remarkup calls to `PhabricatorHash::digest()` with SHA256
ClosedPublic

Authored by epriestley on Apr 6 2017, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 12, 3:18 AM
Unknown Object (File)
Aug 20 2026, 8:50 AM
Unknown Object (File)
Jul 6 2026, 11:42 AM
Unknown Object (File)
Feb 23 2026, 5:51 PM
Unknown Object (File)
Feb 10 2026, 7:37 AM
Unknown Object (File)
Nov 5 2025, 7:03 AM
Unknown Object (File)
Oct 31 2025, 6:24 PM
Unknown Object (File)
Oct 20 2025, 11:32 PM
Subscribers
None

Details

Summary

Ref T12509. Many of the calls to HMAC+SHA1 are just to compute cachekeys for remarkup objects.

Make these use HMAC+SHA256 instead. There is no downside to swapping these since they just cause a cache miss in the worst case.

I also plan to get rid of PhabricatorMarkupInterface eventually, but this doesn't go that far.

Test Plan

Browsed some different types of documents (tasks, legalpad documents, phame blogs / posts, pholio mocks, etc).

Diff Detail

Repository
rP Phabricator
Branch
files22
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16331
Build 21715: Run Core Tests
Build 21714: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 6 2017, 6:25 PM
This revision was automatically updated to reflect the committed changes.