Page MenuHomePhabricator

Replace Remarkup calls to `PhabricatorHash::digest()` with SHA256
ClosedPublic

Authored by epriestley on Apr 6 2017, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:26 AM
Unknown Object (File)
Fri, Apr 19, 6:22 PM
Unknown Object (File)
Thu, Apr 18, 1:03 AM
Unknown Object (File)
Sun, Apr 7, 7:30 PM
Unknown Object (File)
Sat, Mar 30, 7:47 PM
Unknown Object (File)
Sat, Mar 30, 5:00 AM
Unknown Object (File)
Feb 16 2024, 7:23 AM
Unknown Object (File)
Feb 3 2024, 3:27 PM
Subscribers
None

Details

Summary

Ref T12509. Many of the calls to HMAC+SHA1 are just to compute cachekeys for remarkup objects.

Make these use HMAC+SHA256 instead. There is no downside to swapping these since they just cause a cache miss in the worst case.

I also plan to get rid of PhabricatorMarkupInterface eventually, but this doesn't go that far.

Test Plan

Browsed some different types of documents (tasks, legalpad documents, phame blogs / posts, pholio mocks, etc).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 6 2017, 6:25 PM
This revision was automatically updated to reflect the committed changes.