Page MenuHomePhabricator

Replace Remarkup calls to `PhabricatorHash::digest()` with SHA256
ClosedPublic

Authored by epriestley on Apr 6 2017, 5:03 PM.
Tags
None
Referenced Files
F16331137: D17631.diff
Sun, Jun 15, 7:53 PM
Unknown Object (File)
Thu, May 29, 9:14 AM
Unknown Object (File)
May 8 2025, 9:11 AM
Unknown Object (File)
May 8 2025, 7:21 AM
Unknown Object (File)
May 8 2025, 12:13 AM
Unknown Object (File)
May 7 2025, 11:03 AM
Unknown Object (File)
May 6 2025, 8:24 PM
Unknown Object (File)
May 6 2025, 11:32 AM
Subscribers
None

Details

Summary

Ref T12509. Many of the calls to HMAC+SHA1 are just to compute cachekeys for remarkup objects.

Make these use HMAC+SHA256 instead. There is no downside to swapping these since they just cause a cache miss in the worst case.

I also plan to get rid of PhabricatorMarkupInterface eventually, but this doesn't go that far.

Test Plan

Browsed some different types of documents (tasks, legalpad documents, phame blogs / posts, pholio mocks, etc).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 6 2017, 6:25 PM
This revision was automatically updated to reflect the committed changes.