Page MenuHomePhabricator

Replace Remarkup calls to `PhabricatorHash::digest()` with SHA256
ClosedPublic

Authored by epriestley on Apr 6 2017, 5:03 PM.
Tags
None
Referenced Files
F15526522: D17631.diff
Mon, Apr 21, 9:15 PM
F15462716: D17631.id42416.diff
Tue, Apr 1, 5:06 PM
F15462444: D17631.diff
Tue, Apr 1, 3:09 PM
F15461510: D17631.id.diff
Tue, Apr 1, 8:50 AM
F15456921: D17631.diff
Sun, Mar 30, 1:02 PM
F15442428: D17631.id.diff
Wed, Mar 26, 11:24 PM
Unknown Object (File)
Feb 27 2025, 9:14 AM
Unknown Object (File)
Feb 21 2025, 3:19 PM
Subscribers
None

Details

Summary

Ref T12509. Many of the calls to HMAC+SHA1 are just to compute cachekeys for remarkup objects.

Make these use HMAC+SHA256 instead. There is no downside to swapping these since they just cause a cache miss in the worst case.

I also plan to get rid of PhabricatorMarkupInterface eventually, but this doesn't go that far.

Test Plan

Browsed some different types of documents (tasks, legalpad documents, phame blogs / posts, pholio mocks, etc).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 6 2017, 6:25 PM
This revision was automatically updated to reflect the committed changes.