Page MenuHomePhabricator

Replace Remarkup calls to `PhabricatorHash::digest()` with SHA256
ClosedPublic

Authored by epriestley on Apr 6 2017, 5:03 PM.
Tags
None
Referenced Files
F18872943: D17631.id.diff
Wed, Nov 5, 7:03 AM
F18853621: D17631.id42402.diff
Fri, Oct 31, 6:24 PM
F18814586: D17631.diff
Mon, Oct 20, 11:32 PM
F18759140: D17631.id42416.diff
Oct 6 2025, 2:04 AM
F18755713: D17631.id.diff
Oct 5 2025, 7:02 AM
F18648855: D17631.diff
Sep 20 2025, 5:33 PM
F18626176: D17631.id42416.diff
Sep 16 2025, 12:30 AM
F18591495: D17631.diff
Sep 12 2025, 9:24 AM
Subscribers
None

Details

Summary

Ref T12509. Many of the calls to HMAC+SHA1 are just to compute cachekeys for remarkup objects.

Make these use HMAC+SHA256 instead. There is no downside to swapping these since they just cause a cache miss in the worst case.

I also plan to get rid of PhabricatorMarkupInterface eventually, but this doesn't go that far.

Test Plan

Browsed some different types of documents (tasks, legalpad documents, phame blogs / posts, pholio mocks, etc).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 6 2017, 6:25 PM
This revision was automatically updated to reflect the committed changes.