Page MenuHomePhabricator
Differential D17610

Move Files to ModularTransactions
ClosedPublic
Actions

Authored by epriestley on Apr 4 2017, 2:47 PM.
Tags
None
Referenced Files
F14495890: D17610.diff
Fri, Jan 3, 10:41 AM
Unknown Object (File)
Tue, Dec 31, 3:16 PM
Unknown Object (File)
Sat, Dec 14, 8:04 PM
Unknown Object (File)
Mon, Dec 9, 1:23 PM
Unknown Object (File)
Mon, Dec 9, 2:00 AM
Unknown Object (File)
Mon, Dec 9, 2:00 AM
Unknown Object (File)
Mon, Dec 9, 1:56 AM
Unknown Object (File)
Mon, Dec 9, 12:29 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11357: Move Files to EditEngine and modern APIs
Commits
rP8500f78e451c: Move Files to ModularTransactions
Summary

Ref T11357. A lot of file creation doesn't go through transactions, so we only actually have one real transaction type: editing a file name.

Test Plan

Created and edited files.

Screen Shot 2017-04-04 at 7.45.24 AM.png (121×588 px, 14 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 4 2017, 2:47 PM
Harbormaster completed remote builds in B16281: Diff 42354.Apr 4 2017, 2:48 PM
epriestley added inline comments.Apr 4 2017, 2:52 PM
src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php
46

This is a minor fix: newRequiredError() is ignored if the Editor has setContinueOnMissingFields(true) set, but newInvalidError() is always raised.

chad accepted this revision.Apr 4 2017, 5:05 PM
This revision is now accepted and ready to land.Apr 4 2017, 5:05 PM
Closed by commit rP8500f78e451c: Move Files to ModularTransactions (authored by epriestley, committed by epriestley). · Explain WhyApr 4 2017, 5:25 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T12524: Modernize Countdown.Apr 9 2017, 10:42 AM

Revision Contents
Changeset List

PathSize
src/
6 lines
applications/
badges/
xaction/
2 lines
files/
controller/
4 lines
editor/
67 lines
storage/
69 lines
__tests__/
2 lines
xaction/
4 lines
files/
xaction/
badges/
xaction/
PhabricatorFileNameTransaction.php
PhabricatorBadgesBadgeNameTransaction.php
20 lines

Diff 42362

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileEditController.php

Loading...
View Options

src/applications/files/editor/PhabricatorFileEditor.php

Loading...
View Options

src/applications/files/storage/PhabricatorFileTransaction.php

Loading...
View Options

src/applications/files/storage/__tests__/PhabricatorFileTestCase.php

Loading...
View Options

src/applications/files/xaction/PhabricatorFileNameTransaction.php

Loading...
View Options

src/applications/files/xaction/PhabricatorFileTransactionType.php

Loading...
Phabricator · Built by Phacility