Page MenuHomePhabricator

Move Files to ModularTransactions
ClosedPublic

Authored by epriestley on Apr 4 2017, 2:47 PM.
Tags
None
Referenced Files
F17707583: D17610.id42362.diff
Wed, Jul 16, 3:16 PM
F17707330: D17610.id.diff
Wed, Jul 16, 2:52 PM
Unknown Object (File)
Tue, Jul 1, 8:00 PM
Unknown Object (File)
May 29 2025, 9:13 AM
Unknown Object (File)
May 29 2025, 1:03 AM
Unknown Object (File)
May 9 2025, 1:37 AM
Unknown Object (File)
May 6 2025, 3:33 PM
Unknown Object (File)
May 6 2025, 1:02 PM
Subscribers
None

Details

Summary

Ref T11357. A lot of file creation doesn't go through transactions, so we only actually have one real transaction type: editing a file name.

Test Plan

Created and edited files.

Screen Shot 2017-04-04 at 7.45.24 AM.png (121×588 px, 14 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php
46

This is a minor fix: newRequiredError() is ignored if the Editor has setContinueOnMissingFields(true) set, but newInvalidError() is always raised.

This revision is now accepted and ready to land.Apr 4 2017, 5:05 PM
This revision was automatically updated to reflect the committed changes.