Page MenuHomePhabricator

Move Files to ModularTransactions
ClosedPublic

Authored by epriestley on Apr 4 2017, 2:47 PM.

Details

Summary

Ref T11357. A lot of file creation doesn't go through transactions, so we only actually have one real transaction type: editing a file name.

Test Plan

Created and edited files.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 4 2017, 2:47 PM
epriestley added inline comments.Apr 4 2017, 2:52 PM
src/applications/badges/xaction/PhabricatorBadgesBadgeNameTransaction.php
46

This is a minor fix: newRequiredError() is ignored if the Editor has setContinueOnMissingFields(true) set, but newInvalidError() is always raised.

chad accepted this revision.Apr 4 2017, 5:05 PM
This revision is now accepted and ready to land.Apr 4 2017, 5:05 PM
This revision was automatically updated to reflect the committed changes.