Page MenuHomePhabricator

Remove "url" from Elasticsearch index
ClosedPublic

Authored by epriestley on Apr 2 2017, 5:05 PM.
Tags
None
Referenced Files
F15531102: D17600.diff
Wed, Apr 23, 9:40 AM
F15496851: D17600.id42333.diff
Sun, Apr 13, 8:26 AM
F15473693: D17600.id42333.diff
Sun, Apr 6, 12:43 AM
F15469880: D17600.diff
Fri, Apr 4, 5:43 PM
F15439500: D17600.diff
Wed, Mar 26, 7:50 AM
F15431763: D17600.id42337.diff
Mar 24 2025, 2:20 PM
F15397003: D17600.id42333.diff
Mar 16 2025, 5:33 PM
F15342842: D17600.diff
Mar 9 2025, 9:31 PM
Subscribers
None

Details

Summary

Ref T12450. This was added a very very long time ago (D2298).

I don't want to put this in the upstream index anymore because I don't want to encourage third parties to develop software which reads the index directly. Reading the index directly is a big skeleton key which bypasses policy checks.

This was added before much of the policy model existed, when that wasn't as much of a concern. On a tecnhnical note, this also doesn't update when phabricator.base-uri changes.

This can be written as a search index extension if an install relies on it for some bizarre reason, although none should and I'm unaware of any actual use cases in the wild for it, even at Facebook.

Test Plan

Indexed some random stuff into ElasticSearch.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable