Page MenuHomePhabricator

Remove "url" from Elasticsearch index
ClosedPublic

Authored by epriestley on Apr 2 2017, 5:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 16 2017, 5:52 PM
Unknown Object (File)
Apr 10 2017, 8:24 AM
Unknown Object (File)
Apr 10 2017, 8:24 AM
Unknown Object (File)
Apr 10 2017, 8:24 AM
Unknown Object (File)
Apr 9 2017, 12:16 AM
Unknown Object (File)
Apr 5 2017, 2:00 AM
Unknown Object (File)
Apr 2 2017, 6:01 PM
Subscribers
None

Details

Summary

Ref T12450. This was added a very very long time ago (D2298).

I don't want to put this in the upstream index anymore because I don't want to encourage third parties to develop software which reads the index directly. Reading the index directly is a big skeleton key which bypasses policy checks.

This was added before much of the policy model existed, when that wasn't as much of a concern. On a tecnhnical note, this also doesn't update when phabricator.base-uri changes.

This can be written as a search index extension if an install relies on it for some bizarre reason, although none should and I'm unaware of any actual use cases in the wild for it, even at Facebook.

Test Plan

Indexed some random stuff into ElasticSearch.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable