Page MenuHomePhabricator

Make sure writes go to the right cluster
ClosedPublic

Authored by 20after4 on Mar 30 2017, 2:31 AM.
Tags
None
Referenced Files
F10768310: D17581.id42294.diff
Fri, May 27, 4:08 PM
Unknown Object (File)
Apr 12 2017, 10:35 PM
Unknown Object (File)
Apr 10 2017, 11:32 AM
Unknown Object (File)
Apr 10 2017, 11:31 AM
Unknown Object (File)
Apr 10 2017, 11:31 AM
Unknown Object (File)
Apr 9 2017, 1:24 AM
Unknown Object (File)
Apr 3 2017, 10:01 PM
Unknown Object (File)
Mar 30 2017, 5:43 PM
Subscribers

Details

Summary

Two little issues

  1. there was an extra call to getHostForWrite,
  2. The engine instance was shared between multiple service definitions so it

was overwriting the list of writable hosts from one service with hosts from another.

Test Plan

tested in wikimedia production with multiple services defined like this:

language=json
 [
        {
          "hosts": [
            {
              "host": "search.svc.codfw.wmnet",
              "protocol": "https",
              "roles": {
                "read": true,
                "write": true
              },
              "version": 5
            }
          ],
          "path": "/phabricator",
          "port": 9243,
          "type": "elasticsearch"
        },
        {
          "hosts": [
            {
              "host": "search.svc.eqiad.wmnet",
              "protocol": "https",
              "roles": {
                "read": true,
                "write": true
              },
              "version": 5
            }
          ],
          "path": "/phabricator",
          "port": 9243,
          "type": "elasticsearch"
        }
      ]

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable