Page MenuHomePhabricator
Differential D17567

Remove old code for "Request Review" action from Differential
ClosedPublic
Actions

Authored by epriestley on Mar 28 2017, 1:10 PM.
Tags
None
Referenced Files
F18079746: D17567.id42264.diff
Mon, Aug 4, 9:24 PM
F18043408: D17567.id.diff
Sun, Aug 3, 5:49 AM
F18018699: D17567.diff
Sat, Aug 2, 7:07 PM
Unknown Object (File)
Jul 2 2025, 5:12 AM
Unknown Object (File)
Jun 29 2025, 5:34 AM
Unknown Object (File)
Jun 28 2025, 6:26 PM
Unknown Object (File)
May 30 2025, 8:47 AM
Unknown Object (File)
May 29 2025, 8:40 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10967: Move Differential reviewers back to a dedicated database storage table
Commits
rP415ad784844e: Remove old code for "Request Review" action from Differential
Summary

Ref T10967. This moves all remaining "request review" pathways (just differential.createcomment) to the new code, and removes the old action.

Test Plan

Requested review on a revision, grep'd for the action constant.

Diff Detail

Repository
rP Phabricator
Branch
review2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16189
Build 21493: Run Core Tests
Build 21492: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 28 2017, 1:10 PM
Harbormaster completed remote builds in B16189: Diff 42264.Mar 28 2017, 1:11 PM
chad accepted this revision.Mar 28 2017, 5:51 PM
This revision is now accepted and ready to land.Mar 28 2017, 5:51 PM
Closed by commit rP415ad784844e: Remove old code for "Request Review" action from Differential (authored by epriestley, committed by epriestley). · Explain WhyMar 28 2017, 6:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
conduit/
2 lines
editor/
53 lines
storage/
2 lines

Diff 42264

View Options

src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
Phabricator · Built by Phacility