Page MenuHomePhabricator

Remove old code for "Request Review" action from Differential
ClosedPublic

Authored by epriestley on Mar 28 2017, 1:10 PM.
Tags
None
Referenced Files
F14407430: D17567.diff
Tue, Dec 24, 2:54 AM
Unknown Object (File)
Wed, Dec 11, 12:16 PM
Unknown Object (File)
Sat, Dec 7, 9:27 AM
Unknown Object (File)
Fri, Dec 6, 1:26 PM
Unknown Object (File)
Tue, Dec 3, 4:12 PM
Unknown Object (File)
Sat, Nov 30, 8:02 AM
Unknown Object (File)
Fri, Nov 29, 12:40 AM
Unknown Object (File)
Mon, Nov 25, 5:30 AM
Subscribers
None

Details

Summary

Ref T10967. This moves all remaining "request review" pathways (just differential.createcomment) to the new code, and removes the old action.

Test Plan

Requested review on a revision, grep'd for the action constant.

Diff Detail

Repository
rP Phabricator
Branch
review2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16189
Build 21493: Run Core Tests
Build 21492: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 28 2017, 5:51 PM
This revision was automatically updated to reflect the committed changes.