Page MenuHomePhabricator

Don't awaken or scale pools during daemon shutdown
ClosedPublic

Authored by epriestley on Mar 24 2017, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 9:26 AM
Unknown Object (File)
Fri, Jan 3, 4:51 AM
Unknown Object (File)
Fri, Jan 3, 4:44 AM
Unknown Object (File)
Wed, Dec 25, 2:23 PM
Unknown Object (File)
Dec 3 2024, 8:03 PM
Unknown Object (File)
Nov 27 2024, 1:30 PM
Unknown Object (File)
Nov 21 2024, 5:09 PM
Unknown Object (File)
Nov 2 2024, 11:30 AM
Subscribers
None

Details

Summary

Ref T12298. Currently, we may attempt to un-hibernate or scale-up daemon pools during shutdown, which is silly and counterproductive.

Instead, just shut down.

Test Plan

Ran bin/phd restart, saw stuff shut down more cleanly and consistently.

Diff Detail

Repository
rPHU libphutil
Branch
daemon2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16124
Build 21397: Run Core Tests
Build 21396: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 24 2017, 3:34 PM
This revision was automatically updated to reflect the committed changes.