Page MenuHomePhabricator

Don't awaken or scale pools during daemon shutdown
ClosedPublic

Authored by epriestley on Mar 24 2017, 3:23 PM.
Tags
None
Referenced Files
F15549600: D17551.id.diff
Sun, Apr 27, 6:47 AM
F15545312: D17551.diff
Sat, Apr 26, 10:02 AM
F15479891: D17551.id.diff
Tue, Apr 8, 10:03 AM
F15443158: D17551.id42213.diff
Mar 27 2025, 2:47 AM
F15442186: D17551.id42211.diff
Mar 26 2025, 10:03 PM
F15439451: D17551.id.diff
Mar 26 2025, 7:33 AM
F15438956: D17551.id42211.diff
Mar 26 2025, 4:56 AM
F15431247: D17551.diff
Mar 24 2025, 11:17 AM
Subscribers
None

Details

Summary

Ref T12298. Currently, we may attempt to un-hibernate or scale-up daemon pools during shutdown, which is silly and counterproductive.

Instead, just shut down.

Test Plan

Ran bin/phd restart, saw stuff shut down more cleanly and consistently.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 24 2017, 3:34 PM
This revision was automatically updated to reflect the committed changes.