Paths

Table of Contentst

Don't awaken or scale pools during daemon shutdown
ClosedPublic
Actions

Authored by epriestley on Mar 24 2017, 3:23 PM.

Tags

None

Referenced Files

	F15443158: D17551.id42213.diff
	Thu, Mar 27, 2:47 AM

	F15442186: D17551.id42211.diff
	Wed, Mar 26, 10:03 PM

	F15439451: D17551.id.diff
	Wed, Mar 26, 7:33 AM

	F15438956: D17551.id42211.diff
	Wed, Mar 26, 4:56 AM

	F15431247: D17551.diff
	Mon, Mar 24, 11:17 AM

	F15422762: D17551.id42211.diff
	Sat, Mar 22, 10:37 AM

	F15399215: D17551.id42211.diff
	Mon, Mar 17, 3:23 AM

	F15379538: D17551.diff
	Thu, Mar 13, 9:45 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12298: Allow daemon pools to autoscale down to 0 processes

Commits

rPHUbebe54d5762f: Don't awaken or scale pools during daemon shutdown

Summary

Ref T12298. Currently, we may attempt to un-hibernate or scale-up daemon pools during shutdown, which is silly and counterproductive.

Instead, just shut down.

Test Plan

Ran bin/phd restart, saw stuff shut down more cleanly and consistently.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 24 2017, 3:23 PM

Harbormaster completed remote builds in B16124: Diff 42211.Mar 24 2017, 3:24 PM

chad accepted this revision.Mar 24 2017, 3:34 PM

This revision is now accepted and ready to land.Mar 24 2017, 3:34 PM

Closed by commit rPHUbebe54d5762f: Don't awaken or scale pools during daemon shutdown (authored by epriestley, committed by epriestley). · Explain WhyMar 24 2017, 3:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

daemon/

PhutilDaemonOverseer.php

16 lines

PhutilDaemonPool.php

11 lines

Diff 42213

View Options

src/daemon/PhutilDaemonOverseer.php