Page MenuHomePhabricator

Don't awaken or scale pools during daemon shutdown
ClosedPublic

Authored by epriestley on Mar 24 2017, 3:23 PM.
Tags
None
Referenced Files
F12838449: D17551.diff
Thu, Mar 28, 6:13 PM
Unknown Object (File)
Fri, Mar 15, 3:01 PM
Unknown Object (File)
Feb 23 2024, 9:42 PM
Unknown Object (File)
Feb 11 2024, 4:43 AM
Unknown Object (File)
Feb 5 2024, 12:18 AM
Unknown Object (File)
Jan 26 2024, 1:22 AM
Unknown Object (File)
Dec 30 2023, 3:51 AM
Unknown Object (File)
Dec 27 2023, 10:20 AM
Subscribers
None

Details

Summary

Ref T12298. Currently, we may attempt to un-hibernate or scale-up daemon pools during shutdown, which is silly and counterproductive.

Instead, just shut down.

Test Plan

Ran bin/phd restart, saw stuff shut down more cleanly and consistently.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 24 2017, 3:34 PM
This revision was automatically updated to reflect the committed changes.