Page MenuHomePhabricator

Restrict Audit buckets to just ApplicationSearch views
ClosedPublic

Authored by chad on Mar 23 2017, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 12:07 AM
Unknown Object (File)
Feb 13 2024, 2:59 PM
Unknown Object (File)
Feb 3 2024, 3:15 PM
Unknown Object (File)
Jan 24 2024, 8:43 AM
Unknown Object (File)
Jan 24 2024, 6:32 AM
Unknown Object (File)
Jan 16 2024, 5:11 PM
Unknown Object (File)
Jan 12 2024, 4:45 PM
Unknown Object (File)
Jan 1 2024, 4:57 PM
Subscribers

Details

Summary

Fixes T9363. This drops empty buckets from dashboard panel context. Still see full results in Audit.

Test Plan

Create an "Active Audits" panel, add to Dashboard. See no commits found. Check Audit, see all buckets.

Diff Detail

Repository
rP Phabricator
Branch
audit-buckets (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16116
Build 21386: Run Core Tests
Build 21385: arc lint + arc unit

Event Timeline

epriestley added inline comments.
src/applications/audit/query/PhabricatorCommitSearchEngine.php
195

"commit" -> "commits"?

This revision is now accepted and ready to land.Mar 23 2017, 7:30 PM
This revision was automatically updated to reflect the committed changes.