Page MenuHomePhabricator

Record which user accepted on behalf of packages/owners reviewers
ClosedPublic

Authored by epriestley on Mar 22 2017, 6:47 PM.
Tags
None
Referenced Files
F14493367: D17537.diff
Fri, Jan 3, 2:05 AM
Unknown Object (File)
Tue, Dec 31, 4:31 PM
Unknown Object (File)
Tue, Dec 31, 4:30 PM
Unknown Object (File)
Tue, Dec 31, 4:30 PM
Unknown Object (File)
Sun, Dec 29, 2:12 PM
Unknown Object (File)
Thu, Dec 26, 10:37 AM
Unknown Object (File)
Sun, Dec 22, 2:27 AM
Unknown Object (File)
Tue, Dec 10, 11:46 AM
Subscribers
None

Details

Summary

Ref T12271. Don't do anything with this yet, but store who accepted/rejected/whatever on behalf of reviewers.

In the future, we could use this to render stuff like "Blessed Committers (accepted by epriestley)" or whatever. I don't know that this is necessarily super useful, but it's easy to track, seems likely to be useful, and would be a gigantic pain to backfill later if we decide we want it.

Test Plan

Accepted/rejected a revision, saw reviewers update appropriately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 22 2017, 7:52 PM
This revision was automatically updated to reflect the committed changes.