Page MenuHomePhabricator

Record which user accepted on behalf of packages/owners reviewers
ClosedPublic

Authored by epriestley on Mar 22 2017, 6:47 PM.
Tags
None
Referenced Files
F19531858: D17537.id42180.diff
Tue, Jan 20, 7:32 AM
F19530495: D17537.diff
Mon, Jan 19, 10:30 PM
F19528185: D17537.id42180.diff
Mon, Jan 19, 7:31 AM
F19510228: D17537.diff
Sun, Jan 11, 6:27 AM
F19037115: D17537.diff
Nov 25 2025, 10:07 PM
F18976014: D17537.id42182.diff
Nov 16 2025, 11:53 AM
F18750905: D17537.id.diff
Oct 4 2025, 9:14 AM
F18645426: D17537.diff
Sep 19 2025, 7:52 AM
Subscribers
None

Details

Summary

Ref T12271. Don't do anything with this yet, but store who accepted/rejected/whatever on behalf of reviewers.

In the future, we could use this to render stuff like "Blessed Committers (accepted by epriestley)" or whatever. I don't know that this is necessarily super useful, but it's easy to track, seems likely to be useful, and would be a gigantic pain to backfill later if we decide we want it.

Test Plan

Accepted/rejected a revision, saw reviewers update appropriately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 22 2017, 7:52 PM
This revision was automatically updated to reflect the committed changes.