Page MenuHomePhabricator

Record which user accepted on behalf of packages/owners reviewers
ClosedPublic

Authored by epriestley on Mar 22 2017, 6:47 PM.
Tags
None
Referenced Files
F15473909: D17537.id42182.diff
Sun, Apr 6, 3:22 AM
F15464271: D17537.id42180.diff
Wed, Apr 2, 8:04 AM
F15444854: D17537.id.diff
Thu, Mar 27, 11:37 AM
F15442088: D17537.diff
Wed, Mar 26, 9:18 PM
F15441856: D17537.id.diff
Wed, Mar 26, 8:25 PM
F15416395: D17537.id.diff
Thu, Mar 20, 10:52 AM
F15380328: D17537.id42182.diff
Fri, Mar 14, 2:33 AM
Unknown Object (File)
Feb 9 2025, 3:33 AM
Subscribers
None

Details

Summary

Ref T12271. Don't do anything with this yet, but store who accepted/rejected/whatever on behalf of reviewers.

In the future, we could use this to render stuff like "Blessed Committers (accepted by epriestley)" or whatever. I don't know that this is necessarily super useful, but it's easy to track, seems likely to be useful, and would be a gigantic pain to backfill later if we decide we want it.

Test Plan

Accepted/rejected a revision, saw reviewers update appropriately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 22 2017, 7:52 PM
This revision was automatically updated to reflect the committed changes.