Page MenuHomePhabricator

Record which user accepted on behalf of packages/owners reviewers
ClosedPublic

Authored by epriestley on Mar 22 2017, 6:47 PM.
Tags
None
Referenced Files
F17925622: D17537.id.diff
Jul 30 2025, 11:47 AM
F17752613: D17537.diff
Jul 22 2025, 7:25 AM
Unknown Object (File)
Jul 3 2025, 9:38 PM
Unknown Object (File)
Jun 29 2025, 6:39 PM
Unknown Object (File)
Jun 5 2025, 10:40 AM
Unknown Object (File)
May 29 2025, 10:20 AM
Unknown Object (File)
May 28 2025, 6:28 PM
Unknown Object (File)
May 7 2025, 10:57 AM
Subscribers
None

Details

Summary

Ref T12271. Don't do anything with this yet, but store who accepted/rejected/whatever on behalf of reviewers.

In the future, we could use this to render stuff like "Blessed Committers (accepted by epriestley)" or whatever. I don't know that this is necessarily super useful, but it's easy to track, seems likely to be useful, and would be a gigantic pain to backfill later if we decide we want it.

Test Plan

Accepted/rejected a revision, saw reviewers update appropriately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 22 2017, 7:52 PM
This revision was automatically updated to reflect the committed changes.