Page MenuHomePhabricator

Record which user accepted on behalf of packages/owners reviewers
ClosedPublic

Authored by epriestley on Mar 22 2017, 6:47 PM.
Tags
None
Referenced Files
F13998471: D17537.diff
Thu, Oct 24, 9:25 AM
F13969327: D17537.diff
Thu, Oct 17, 1:56 AM
F13963953: D17537.id42180.diff
Tue, Oct 15, 6:52 PM
F13963035: D17537.id42182.diff
Tue, Oct 15, 1:40 PM
Unknown Object (File)
Sun, Oct 13, 9:26 AM
Unknown Object (File)
Sun, Oct 13, 12:51 AM
Unknown Object (File)
Sat, Oct 12, 4:52 AM
Unknown Object (File)
Fri, Oct 11, 2:18 AM
Subscribers
None

Details

Summary

Ref T12271. Don't do anything with this yet, but store who accepted/rejected/whatever on behalf of reviewers.

In the future, we could use this to render stuff like "Blessed Committers (accepted by epriestley)" or whatever. I don't know that this is necessarily super useful, but it's easy to track, seems likely to be useful, and would be a gigantic pain to backfill later if we decide we want it.

Test Plan

Accepted/rejected a revision, saw reviewers update appropriately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 22 2017, 7:52 PM
This revision was automatically updated to reflect the committed changes.