Paths

Table of Contentst

Differential D17536

Don't require mentioned objects to have all required fields when editing comments
ClosedPublic
Actions

Authored by epriestley on Mar 22 2017, 4:55 PM.

Tags

None

Referenced Files

	F14076791: D17536.diff
	Thu, Nov 21, 7:43 PM

	Unknown Object (File)
	Thu, Nov 21, 9:53 AM

	Unknown Object (File)
	Thu, Nov 21, 3:59 AM

	Unknown Object (File)
	Sun, Nov 17, 4:10 PM

	Unknown Object (File)
	Thu, Nov 14, 7:49 AM

	Unknown Object (File)
	Sun, Nov 10, 4:53 AM

	Unknown Object (File)
	Sat, Nov 9, 8:39 PM

	Unknown Object (File)
	Wed, Nov 6, 1:42 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12439: Maniphest comment editing fails with required custom field and edge

Commits

rP9c998e988b1d: Don't require mentioned objects to have all required fields when editing…

Summary

Fixes T12439. This pathway was just missing a setContinueOnMissingFields(...) to skip enforcement of required fields.

Test Plan

Added a required custom field.
Mentioned any task without a field value in a comment.
Edited that comment.
Saved changes.
Before fix: fatal in log.
After fix: clean edit.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 22 2017, 4:55 PM

chad accepted this revision.Mar 22 2017, 4:55 PM

This revision is now accepted and ready to land.Mar 22 2017, 4:55 PM

Harbormaster completed remote builds in B16091: Diff 42176.Mar 22 2017, 4:56 PM

Closed by commit rP9c998e988b1d: Don't require mentioned objects to have all required fields when editing… (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2017, 4:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionCommentEditor.php

1 line

Diff 42178

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

Loading...