Page MenuHomePhabricator

Don't require mentioned objects to have all required fields when editing comments
ClosedPublic

Authored by epriestley on Mar 22 2017, 4:55 PM.
Tags
None
Referenced Files
F18779127: D17536.id42176.diff
Oct 11 2025, 12:19 PM
F18733527: D17536.id.diff
Sep 30 2025, 10:36 PM
F18724861: D17536.id42178.diff
Sep 30 2025, 4:07 AM
F18709113: D17536.id.diff
Sep 28 2025, 11:43 PM
F18613844: D17536.diff
Sep 14 2025, 11:33 AM
F18601523: D17536.diff
Sep 13 2025, 12:43 PM
F18596455: D17536.diff
Sep 13 2025, 12:43 AM
F18593408: D17536.diff
Sep 12 2025, 2:50 PM
Subscribers
None

Details

Summary

Fixes T12439. This pathway was just missing a setContinueOnMissingFields(...) to skip enforcement of required fields.

Test Plan
  • Added a required custom field.
  • Mentioned any task without a field value in a comment.
  • Edited that comment.
  • Saved changes.
  • Before fix: fatal in log.
  • After fix: clean edit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable