Paths

Table of Contentst

Differential D17522

Rename "getReviewerStatus()" to "getReviewers()"
ClosedPublic
Actions

Authored by epriestley on Mar 20 2017, 10:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 12:18 AM

	Unknown Object (File)
	Fri, Nov 15, 10:37 AM

	Unknown Object (File)
	Sun, Nov 10, 11:36 PM

	Unknown Object (File)
	Sun, Nov 10, 10:36 PM

	Unknown Object (File)
	Sun, Nov 10, 8:22 PM

	Unknown Object (File)
	Thu, Nov 7, 1:48 AM

	Unknown Object (File)
	Mon, Nov 4, 5:13 PM

	Unknown Object (File)
	Mon, Nov 4, 2:31 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10967: Move Differential reviewers back to a dedicated database storage table

Commits

rP0ceab7d36f91: Rename "getReviewerStatus()" to "getReviewers()"

Summary

Ref T10967. Improves some method names:

Revision->getReviewerStatus() -> Revision->getReviewers()
Revision->attachReviewerStatus() -> Revision->attachReviewers()
Reviewer->getStatus() -> Reviewer->getReviewerStatus() (this is mostly to make this more greppable)

Test Plan

bunch o' grep
Browsed around.
If I missed anything, it should fatal in an obvious way. We have a lot of other getStatus() calls and it's hard to be sure I got them all.

Diff Detail

Repository

Branch

rev9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16050
Build 21288: Run Core Tests
Build 21287: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 20 2017, 10:09 PM

Harbormaster completed remote builds in B16050: Diff 42135.Mar 20 2017, 10:10 PM

chad added inline comments.Mar 20 2017, 11:46 PM

src/applications/differential/storage/DifferentialRevision.php
73	attachReviewers?

attachReviewer() -> attachReviewers()

chad accepted this revision.Mar 20 2017, 11:49 PM

This revision is now accepted and ready to land.Mar 20 2017, 11:49 PM

Harbormaster completed remote builds in B16059: Diff 42144.Mar 20 2017, 11:49 PM

Fix one more getStatus().
Fix one getReviewer*s*Status().
Tune a bit of behavior around differential.sticky-accept.

Harbormaster completed remote builds in B16060: Diff 42145.Mar 21 2017, 12:09 AM

Closed by commit rP0ceab7d36f91: Rename "getReviewerStatus()" to "getReviewers()" (authored by epriestley, committed by epriestley). · Explain WhyMar 21 2017, 12:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

DifferentialCreateRevisionConduitAPIMethod.php

2 lines

customfield/

DifferentialProjectReviewersField.php

2 lines

DifferentialReviewersField.php

4 lines

editor/

DifferentialTransactionEditor.php

20 lines

engineextension/

DifferentialHovercardEngineExtension.php

3 lines

field/

DifferentialReviewedByCommitMessageField.php

5 lines

DifferentialReviewersCommitMessageField.php

4 lines

herald/

DifferentialReviewersHeraldAction.php

3 lines

HeraldDifferentialRevisionAdapter.php

3 lines

lipsum/

PhabricatorDifferentialRevisionTestDataGenerator.php

2 lines

query/

DifferentialRevisionQuery.php

2 lines

DifferentialRevisionResultBucket.php

4 lines

search/

DifferentialRevisionFulltextEngine.php

7 lines

storage/

DifferentialReviewer.php

6 lines

DifferentialRevision.php

17 lines

xaction/

DifferentialRevisionReviewTransaction.php

10 lines

DifferentialRevisionReviewersTransaction.php

4 lines

repository/

worker/

PhabricatorRepositoryCommitOwnersWorker.php

4 lines

Diff 42135

src/applications/differential/conduit/DifferentialCreateRevisionConduitAPIMethod.php

Loading...

src/applications/differential/customfield/DifferentialProjectReviewersField.php

Loading...

src/applications/differential/customfield/DifferentialReviewersField.php

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/differential/engineextension/DifferentialHovercardEngineExtension.php

Loading...

src/applications/differential/field/DifferentialReviewedByCommitMessageField.php

Loading...

src/applications/differential/field/DifferentialReviewersCommitMessageField.php

Loading...

src/applications/differential/herald/DifferentialReviewersHeraldAction.php

Loading...

src/applications/differential/herald/HeraldDifferentialRevisionAdapter.php

Loading...

src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php

Loading...

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...

src/applications/differential/query/DifferentialRevisionResultBucket.php

Loading...

src/applications/differential/search/DifferentialRevisionFulltextEngine.php

Loading...

src/applications/differential/storage/DifferentialReviewer.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php

Loading...

src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php

Loading...

src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php

Loading...