Page MenuHomePhabricator

Move many "reviewers" readers to new storage
ClosedPublic

Authored by epriestley on Mar 20 2017, 8:24 PM.
Tags
None
Referenced Files
F14100019: D17517.diff
Tue, Nov 26, 1:09 PM
Unknown Object (File)
Mon, Nov 25, 8:26 AM
Unknown Object (File)
Thu, Nov 21, 6:21 AM
Unknown Object (File)
Sun, Nov 17, 1:24 AM
Unknown Object (File)
Tue, Oct 29, 8:35 PM
Unknown Object (File)
Oct 18 2024, 3:21 PM
Unknown Object (File)
Oct 9 2024, 7:39 AM
Unknown Object (File)
Oct 1 2024, 11:38 PM
Subscribers
None

Details

Summary

Ref T10967.

When we query for revisions with particular reviewers, use the new table to drive the query.

When we load revisions for use in the application, also use the new table to drive the query.

This doesn't convert everything: there's some old loadRelationships() stuff still using the old table. But this moves the major stuff over.

(This also changes the icon for "commented" from a question mark to a speech bubble.)

Test Plan
  • Viewed revision lists and detail views on old and new code, saw identical outcomes.
  • Updated revisions, accepted/rejected/commented on revisions.
  • Hit the "Accepted Older" and "Commented Older" states by taking an action and then updating.
  • Grepped for removed methods (like getEdgeData() and getDiffID()).

Diff Detail

Repository
rP Phabricator
Branch
rev6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/storage/DifferentialReviewer.php:31XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 16041
Build 21273: Run Core Tests
Build 21272: arc lint + arc unit

Event Timeline

chad added inline comments.
src/applications/differential/customfield/DifferentialCustomField.php
78

?

This revision is now accepted and ready to land.Mar 20 2017, 9:47 PM
src/applications/differential/customfield/DifferentialCustomField.php
78

It's possible that getActiveDiff() isn't loaded in some cases so we'd get a "thing not attached" exception. Since all we need it for is to pretty-up the UI I'm just blarpin' out.

This revision was automatically updated to reflect the committed changes.